You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/09 16:57:03 UTC

[GitHub] [spark] srowen commented on pull request #36467: [SPARK-39063][CORE] Fix potential risk of JVM crash and `RocksDBIterator` resource leak

srowen commented on PR #36467:
URL: https://github.com/apache/spark/pull/36467#issuecomment-1121345960

   This seems like a well thought-out change, though it's complex compared to the issue it's trying to solve - a setting of a non-default third party library. I'm neutral about bothering with it if 'normal' rocksdb does not have this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org