You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2026/05/11 21:13:20 UTC
[PR] New SolrJ CollectionScopedSolrClient [solr]
dsmiley opened a new pull request, #4418:
URL: https://github.com/apache/solr/pull/4418
This SolrClient delegates to a backing client with a specified collection. Simple attempts to refer to another collection will fail. DISCLAIMER: this isn't a security mechanism.
There are tests and places in client code I've seen that would benefit from this. For one thing, it enables taking an existing SolrClient that doesn't have a defaultCollection (e.g. JettySolrRunner.getSolrClient()) and simply wrap it. Voila. I'm working on Jetty -> Apache transition and in the process I'm moving needless client creations to use existing clients, and I want to use this. I don't want this to "sneak in" within a test-focused PR.
I'll probably add a changelog but wasn't going to add a JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] New SolrJ CollectionScopedSolrClient [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4418:
URL: https://github.com/apache/solr/pull/4418#issuecomment-4450863669
gonna merge this little thing this weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] New SolrJ CollectionScopedSolrClient [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #4418:
URL: https://github.com/apache/solr/pull/4418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] New SolrJ CollectionScopedSolrClient [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4418:
URL: https://github.com/apache/solr/pull/4418#issuecomment-4425257261
It could use a nice `toString` -- I'll add one: `delegate + "/" + defaultSolrCollection`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] New SolrJ CollectionScopedSolrClient [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4418:
URL: https://github.com/apache/solr/pull/4418#issuecomment-4425299342
Out of scope here... I remain troubled by the excessive overloading of methods on SolrClient that take a collection param. I'd rather see them all gone; SolrClient just talks to a node but has a method to return a CollectionOperationsClient interface implementation (a new thing). It wouldn't subclass SolrClient; it's just a bunch of methods users expect send requests that are collection-scoped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org