You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhouyuan (via GitHub)" <gi...@apache.org> on 2026/09/15 10:09:04 UTC
[PR] Revert "[GLUTEN-12911][VL] Fix memory pool holding in async thread" [gluten]
zhouyuan opened a new pull request, #13029:
URL: https://github.com/apache/gluten/pull/13029
Reverts apache/gluten#12919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] Revert "[GLUTEN-12911][VL] Fix memory pool holding in async thread" [gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan merged PR #13029:
URL: https://github.com/apache/gluten/pull/13029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] Revert "[GLUTEN-12911][VL] Fix memory pool holding in async thread" [gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #13029:
URL: https://github.com/apache/gluten/pull/13029#issuecomment-5683560911
Cc @boneanxs @FelixYBW reverted here to unblock the CI, will need a fix on the deadlock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] Revert "[GLUTEN-12911][VL] Fix memory pool holding in async thread" [gluten]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13029:
URL: https://github.com/apache/gluten/pull/13029#discussion_r4017683024
##########
cpp/velox/memory/GlutenDirectBufferedInput.h:
##########
@@ -81,25 +34,21 @@ class GlutenDirectBufferedInput : private detail::ExecutorBarrierHolder,
folly::Executor* executor,
const facebook::velox::io::ReaderOptions& readerOptions,
folly::F14FastMap<std::string, std::string> fileReadOps = {})
- : ExecutorBarrierHolder(executor),
- DirectBufferedInput(
+ : DirectBufferedInput(
std::move(readFile),
metricsLog,
std::move(fileNum),
std::move(tracker),
std::move(groupId),
std::move(ioStatistics),
std::move(ioStats),
- barrier(),
+ executor,
Review Comment:
Passing the raw executor here removes the only per-input drain for queued async loads. The destructor cancels `kPlanned` loads and clears them, but a not-yet-scheduled `AsyncLoadHolder` can remain queued on the executor and retain the task's `MemoryPool` until after this input/runtime is torn down; this is the `pools_.size() != 0` failure tracked by #12911. Please retain an equivalent barrier/drain (or include the alternative fix) rather than reverting to the raw executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org