You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2007/08/27 08:32:56 UTC
svn commit: r570015 -
/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/InlineFrame.java
Author: ivaynberg
Date: Sun Aug 26 23:32:55 2007
New Revision: 570015
URL: http://svn.apache.org/viewvc?rev=570015&view=rev
Log:
WICKET-887
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/InlineFrame.java
Modified: wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/InlineFrame.java
URL: http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/InlineFrame.java?rev=570015&r1=570014&r2=570015&view=diff
==============================================================================
--- wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/InlineFrame.java (original)
+++ wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/link/InlineFrame.java Sun Aug 26 23:32:55 2007
@@ -35,6 +35,7 @@
* @author Sven Meier
* @author Ralf Ebert
*/
+
public class InlineFrame extends WebMarkupContainer implements ILinkListener
{
private static final long serialVersionUID = 1L;
@@ -220,5 +221,22 @@
public final IPageMap getPageMap()
{
return PageMap.forName(pageMapName);
+ }
+
+ protected boolean getStatelessHint()
+ {
+ /*
+ * TODO optimization: the inlineframe component does not always have to be stateless.
+ *
+ * unfortunately due to current implementation always using ipagelink and a ilinklistener
+ * callback it has to always be *stateful* because it can be put inside a listview item
+ * which will not be built upon a stateless callback causing a "component at path
+ * listview:0:iframe not found" error.
+ *
+ * eventually variant such as (string, ipagemap, class<? extends Page>) can be made
+ * stateless because they can generate a bookmarkable url. another advantage of a
+ * bookmarkable url is that multiple iframes will not block.
+ */
+ return false;
}
}