You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/03/12 17:42:39 UTC

[GitHub] [drill] paul-rogers commented on a change in pull request #2010: DRILL-7620: Fix plugin mutability issues

paul-rogers commented on a change in pull request #2010: DRILL-7620: Fix plugin mutability issues
URL: https://github.com/apache/drill/pull/2010#discussion_r391761129
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java
 ##########
 @@ -505,14 +530,19 @@ public StoragePluginConfig copyConfig(StoragePluginConfig orig) {
 
   @Override
   public StoragePluginConfig getDefinedConfig(String name) {
+    try {
+      name = validateName(name);
+    } catch (PluginException e) {
 
 Review comment:
   Added comment. The name is not valid so no config matches the name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services