You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2026/08/19 06:37:33 UTC
[PR] Correct the common-ai toolset list and document the shields extra [airflow]
Lee-W opened a new pull request, #71819:
URL: https://github.com/apache/airflow/pull/71819
The toolsets guide told readers that four toolsets were included, but documented seven. The three extra ones are not re-exported from the package root, so anyone importing them the way the first four are imported hits an ImportError with nothing in the guide to explain it. The extras list also never mentioned shields, leaving no way to find out which extra installs the guardrail support the agent guide describes.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: [Claude] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct the common-ai toolset list and document the shields extra [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #71819:
URL: https://github.com/apache/airflow/pull/71819#discussion_r3810857635
##########
providers/common/ai/docs/toolsets.rst:
##########
@@ -37,7 +38,14 @@ Four toolsets are included:
the agent a shell and a filesystem inside an isolated sandbox, off the
Airflow worker. See :ref:`which boundary that is <sandbox-boundaries>`.
-All four implement pydantic-ai's
+Three more toolsets are documented later on this page. They are not re-exported from the
+package root, so import each of them from its own submodule::
Review Comment:
A bit confusing to me, why can we not mention whats in the package root vs whats in submodules? We can just mention _all of them_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct the common-ai toolset list and document the shields extra [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #71819:
URL: https://github.com/apache/airflow/pull/71819#discussion_r3811342388
##########
providers/common/ai/docs/toolsets.rst:
##########
@@ -37,7 +38,14 @@ Four toolsets are included:
the agent a shell and a filesystem inside an isolated sandbox, off the
Airflow worker. See :ref:`which boundary that is <sandbox-boundaries>`.
-All four implement pydantic-ai's
+Three more toolsets are documented later on this page. They are not re-exported from the
+package root, so import each of them from its own submodule::
Review Comment:
Right, I guess I just wanted to separate them based on different source. But merging them is way easier to read. Thanks! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Correct the common-ai toolset list and document the shields extra [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #71819:
URL: https://github.com/apache/airflow/pull/71819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org