You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "zhipeng93 (via GitHub)" <gi...@apache.org> on 2023/02/10 07:54:21 UTC

[GitHub] [flink-ml] zhipeng93 commented on pull request #206: [FLINK-30933] Fix missing max watermark when executing join in iteration body

zhipeng93 commented on PR #206:
URL: https://github.com/apache/flink-ml/pull/206#issuecomment-1425353355

   > As a whole LGTM, and @zhipeng93 could you modify the test to also check the max watermark is indeed emitted before termination?
   
   Thanks for the reply. The unit test here [1] already verifies that the max watermark is emitted. If there is no max watermark, there should be no output and the unit test should fail. Do you mean we directly check that max watermark is emitted?
   
   [1] https://github.com/apache/flink-ml/pull/206/files#diff-0d6c01f07abbec3796dfa449243437549c19615dd6439a27af08b6b68005e8a4R127


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org