[orchestra] FrameworkAdapter setup (was Re: [orchestra] servlet filters ..)

[Mario Ivankovits <ma...@ops.co.at>]

Hi!
>>> So I am fine by adding some Framework-Adapter specified stuff to the
>>> OrchestraServletFilter - instead of creating a new filter.
>>>       
>> Isn't OrchestraServletFilter currently optional [1]? Using it to set up
>> the FrameworkAdapter would make it mandatory...
>>     
>
> Sorry Mario, I should have read your email more carefully. As
> OrchestraServletFilter *is* required when using JsfFrameworkAdapter,
> then setting the FrameworkAdapter threadlocal makes perfect sense there.
>   
Simon, I've never received a message with the text "Isn't
OrchestraServletFilter ....".
I hope there are no other messages I've lost from you :-(

I am currently cleaning up the RequestParameterProvider (as proposed by
Matthias). I'll now provide a FacesContextFactory and the filter.
When testing the filter I've found, that it also requires the
FrameworkAdapter which requires the OrchestraServletFilter to have the
httpServlet* thread-locals setup appropriate.
Now, my test is to configure the RequestParameterServletFilter for a non
JSF request - currently it fails as the OrchestraServletFilter has not
been configured for such non JSF requests - and I think it is not a good
idea to do so.

What if we create a FrameworkAdapterFilter to setup the stuff required
for the FrameworkAdapter itself. It makes things cleaner, no?
Though, then we have yet another configuration option ... :-(
Maybe we can call the FrameworkAdapterFilter from the
OrchestraServletFilter so that one has to configure the
FrameworkAdapterFilter only in special cases.

What do you think?

Ciao,
Mario

Re: [orchestra] FrameworkAdapter setup (was Re: [orchestra] servlet filters ..)

[Mario Ivankovits <ma...@ops.co.at>]

Hi!
>> What if we create a FrameworkAdapterFilter to setup the stuff required
>> for the FrameworkAdapter itself. It makes things cleaner, no?
>> Though, then we have yet another configuration option ... :-(
>> Maybe we can call the FrameworkAdapterFilter from the
>> OrchestraServletFilter so that one has to configure the
>> FrameworkAdapterFilter only in special cases.
>>
>> What do you think?
>>     
>
> So you mean create a separate FrameworkAdapterFilter, then in
> OrchestraServletFilter, have
>
>   private FrameworkAdapterFilter subfilter = 
>     new FrameworkAdapterFilter();
>   
Exactly! ... committed :-)


Ciao,
Mario

Re: [orchestra] FrameworkAdapter setup (was Re: [orchestra] servlet filters ..)

[simon <sk...@apache.org>]

On Sun, 2007-08-19 at 13:07 +0200, Mario Ivankovits wrote:
> I am currently cleaning up the RequestParameterProvider (as proposed by
> Matthias). I'll now provide a FacesContextFactory and the filter.
> When testing the filter I've found, that it also requires the
> FrameworkAdapter which requires the OrchestraServletFilter to have the
> httpServlet* thread-locals setup appropriate.
> Now, my test is to configure the RequestParameterServletFilter for a non
> JSF request - currently it fails as the OrchestraServletFilter has not
> been configured for such non JSF requests - and I think it is not a good
> idea to do so.
> 
> What if we create a FrameworkAdapterFilter to setup the stuff required
> for the FrameworkAdapter itself. It makes things cleaner, no?
> Though, then we have yet another configuration option ... :-(
> Maybe we can call the FrameworkAdapterFilter from the
> OrchestraServletFilter so that one has to configure the
> FrameworkAdapterFilter only in special cases.
> 
> What do you think?

So you mean create a separate FrameworkAdapterFilter, then in
OrchestraServletFilter, have

  private FrameworkAdapterFilter subfilter = 
    new FrameworkAdapterFilter();

and instead of 

  filterChain.doFilter(....)

call

  subfilter.doFilter(...., filterChain)

?

That seems reasonably elegant to me..

Regards,

Simon

Re: [orchestra] missing emails from me

[Mario Ivankovits <ma...@ops.co.at>]

Hi!
>> Simon, I've never received a message with the text "Isn't
>> OrchestraServletFilter ....".
>> I hope there are no other messages I've lost from you :-(
>>     
>
> Aargh, yes there are.
>   
</snip>

Ouch - I already wondered why you didn't respond to my responses :-)


Ciao,
Mario

Re: [orchestra] missing emails from me

[simon <sk...@apache.org>]

On Sun, 2007-08-19 at 13:07 +0200, Mario Ivankovits wrote:
> Simon, I've never received a message with the text "Isn't
> OrchestraServletFilter ....".
> I hope there are no other messages I've lost from you :-(

Aargh, yes there are.

My stupid email client (Evolution) is set up with two addresses - my
apache.org one and my chello.at one. I've set it up so that new messages
use the apache one by default. However when I reply to a message, the
from address is being set to my chello address by default and I cannot
find any way to fix this.

And it appears that the moderator for the dev@myfaces list has denied my
chello.at address. So every reply where I forget to reset the from
address has never made it to the dev list [the moderator for the user
list *has* allowed the chello address].

I'll try to get my alternate address allowed here. In the meantime I'll
repost all the ones that went missing...

Regards,

Simon