You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "massucattoj (via GitHub)" <gi...@apache.org> on 2026/05/07 01:12:19 UTC
[PR] fix(explore): hide value input for unary filter operators [superset]
massucattoj opened a new pull request, #39924:
URL: https://github.com/apache/superset/pull/39924
### SUMMARY
In the Explore filter popover (Simple tab), when a unary operator was selected
(`IS NULL`, `IS NOT NULL`, `IS TRUE`, `IS FALSE`), the value input below the
operator dropdown was rendered in a disabled (grayed-out) state instead of
being hidden. Disabled inputs that can never be interacted with create visual
noise and confuse users about what is required to complete the filter.
This change hides the value control entirely whenever the selected operator
appears in `DISABLE_INPUT_OPERATORS`, so only the column and operator fields
are shown for unary operators.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:**
<img width="380" height="336" alt="Screenshot 2026-05-06 at 22 11 50" src="https://github.com/user-attachments/assets/990b135b-da56-4928-986a-43e4bc1ec7be" />
**After:**
<img width="370" height="332" alt="Screenshot 2026-05-06 at 22 10 58" src="https://github.com/user-attachments/assets/98066044-3e84-4d18-86e3-85a6d06d930c" />
<!-- attach the before/after screenshots here -->
### TESTING INSTRUCTIONS
1. Open any chart in Explore (e.g. a Table chart on `birth_names` or any
dataset).
2. In the **FILTERS** section, click an existing filter or `+ Add filter`.
3. Switch to the **SIMPLE** tab.
4. Pick any column.
5. Change the operator to `Is null`, `Is not null`, `Is true`, or `Is false`.
6. **Expected:** the value input below the operator does **not** render at
all (previously it rendered as a disabled/grayed input).
7. Switching back to a non-unary operator (e.g. `Equal to`, `In`) should
restore the value input.
Automated coverage: see four new tests in
`AdhocFilterEditPopoverSimpleTabContent.test.tsx` asserting that the value
input is not in the document for each unary operator.
### ADDITIONAL INFORMATION
- [ ] Has associated issue: <!-- fill in if a GH issue exists -->
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): hide value input for unary filter operators [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39924:
URL: https://github.com/apache/superset/pull/39924#issuecomment-4526015107
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39924?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.20%. Comparing base ([`5003ee1`](https://app.codecov.io/gh/apache/superset/commit/5003ee1499a2543eea9005d1454b18f199b4d5d6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`45b7b55`](https://app.codecov.io/gh/apache/superset/commit/45b7b55bca9b8d195104109b0fd1a6d839c0d44a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39924 +/- ##
=======================================
Coverage 64.20% 64.20%
=======================================
Files 2592 2592
Lines 139232 139232
Branches 32327 32327
=======================================
Hits 89389 89389
Misses 48308 48308
Partials 1535 1535
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/39924/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/39924/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.33% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39924?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): hide value input for unary filter operators [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on PR #39924:
URL: https://github.com/apache/superset/pull/39924#issuecomment-4479925037
@massucattoj looks ready to go after a rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): hide value input for unary filter operators [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe merged PR #39924:
URL: https://github.com/apache/superset/pull/39924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): hide value input for unary filter operators [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39924:
URL: https://github.com/apache/superset/pull/39924#issuecomment-4393350412
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): hide value input for unary filter operators [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39924:
URL: https://github.com/apache/superset/pull/39924#issuecomment-4526385974
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org