[GitHub] [flink] zentol commented on a diff in pull request #19680: [FLINK-27457] Implement flush() logic in Cassandra output formats

[GitBox <gi...@apache.org>]

zentol commented on code in PR #19680:
URL: https://github.com/apache/flink/pull/19680#discussion_r873541618


##########
flink-core/src/main/java/org/apache/flink/api/common/io/OutputFormat.java:
##########
@@ -71,9 +71,10 @@
      * <p>When this method is called, the output format it guaranteed to be opened.
      *
      * @param record The records to add to the output.
-     * @throws IOException Thrown, if the records could not be added to to an I/O problem.
+     * @throws Exception Thrown, if the records could not be added due to an I/O problem or a
+     *     timeout.
      */
-    void writeRecord(IT record) throws IOException;
+    void writeRecord(IT record) throws Exception;

Review Comment:
   -1; this change breaks source-compatibility with all existing implementations.
   
   Need to double-check why japicmp didn't notice this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org