You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by wi...@apache.org on 2021/07/23 18:26:51 UTC
[orc] branch main updated: ORC-857: Add
OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
This is an automated email from the ASF dual-hosted git repository.
william pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/main by this push:
new b34da1b ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
b34da1b is described below
commit b34da1b6ea37802b8ed966c3aded7fa79ffaee4e
Author: William Hyun <wi...@apache.org>
AuthorDate: Fri Jul 23 11:12:19 2021 -0700
ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.
* What changes were proposed in this pull request?
This PR aims to add Java checkstyle rules OuterTypeFilename, UpperEll, and ArrayTypeStyle.
* Why are the changes needed?
To improve code quality.
* How was this patch tested?
Pass the GHA.
Closes #759.
Signed-off-by: William Hyun <wi...@apache.org>
---
java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java | 2 +-
java/core/src/java/org/apache/orc/util/BloomFilterIO.java | 2 +-
java/pom.xml | 3 +++
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java b/java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
index cfc1e53..abd9eab 100644
--- a/java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
+++ b/java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
@@ -124,7 +124,7 @@ public class RunLengthIntegerWriterV2 implements IntegerWriter {
static final int MAX_SCOPE = 512;
static final int MIN_REPEAT = 3;
- static final long BASE_VALUE_LIMIT = 1l << 56;
+ static final long BASE_VALUE_LIMIT = 1L << 56;
private static final int MAX_SHORT_REPEAT_LENGTH = 10;
private long prevDelta = 0;
private int fixedRunLength = 0;
diff --git a/java/core/src/java/org/apache/orc/util/BloomFilterIO.java b/java/core/src/java/org/apache/orc/util/BloomFilterIO.java
index 74e9b0a..4aa9879 100644
--- a/java/core/src/java/org/apache/orc/util/BloomFilterIO.java
+++ b/java/core/src/java/org/apache/orc/util/BloomFilterIO.java
@@ -78,7 +78,7 @@ public class BloomFilterIO {
int numFuncs = bloomFilter.getNumHashFunctions();
switch (kind) {
case BLOOM_FILTER: {
- long values[] = new long[bloomFilter.getBitsetCount()];
+ long[] values = new long[bloomFilter.getBitsetCount()];
for (int i = 0; i < values.length; ++i) {
values[i] = bloomFilter.getBitset(i);
}
diff --git a/java/pom.xml b/java/pom.xml
index 20e9a4f..4597e08 100644
--- a/java/pom.xml
+++ b/java/pom.xml
@@ -284,7 +284,10 @@
<property name="message" value="No trailing white space allowed."/>
</module>
<module name="TreeWalker">
+ <module name="OuterTypeFilename"/>
<module name="UnusedImports"/>
+ <module name="UpperEll"/>
+ <module name="ArrayTypeStyle"/>
</module>
</module>
</checkstyleRules>