You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/29 14:18:10 UTC
[GitHub] [dolphinscheduler] DarkAssassinator opened a new pull request, #11693: Fix porcess instance duration
DarkAssassinator opened a new pull request, #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
fix #11669
## Brief change log
1. Set the update strategy of field ProcessInstance#endTime to @TableField(updateStrategy = FieldStrategy.IGNORED). Because now setEndTime(null) cannot take affect.
2. When processInstance is running or serial wait, the val of workflow instance duration should be null.
3. Add a condition in DateUtils.format2Duration, make sure that startTime must before endTime.
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
re-run a workflow instance, then check the endTime and duration.
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1265455188
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11693)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_coverage&view=list) [60.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on code in PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#discussion_r963866477
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessInstance.java:
##########
@@ -77,6 +74,7 @@ public class ProcessInstance {
/**
* end time
*/
+ @TableField(updateStrategy = FieldStrategy.IGNORED)
Review Comment:
> Please don't use this way, because it's a hide way for upper callers, will cause other problems if users don't know.
emm, but also we cannot config the global field-strategy, may we can add a update sql in mapper.xml?
Or just update the date to 1970, but need change many files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1241922185
Hi @DarkAssassinator I think you can use the `restartTime` field in processInstance to calculate the duration when restart.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1265456493
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11693)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_coverage&view=list) [55.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator closed pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
DarkAssassinator closed pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
URL: https://github.com/apache/dolphinscheduler/pull/11693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1272336197
wrong PR, contain many history records, close it and then will re-open a new PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1245465143
> > But the UI page still will show the last EndTime, but re-run still running, not finish. So i think that we need to make sure that setEndTime(null) can take affect
>
> OK, but can we replace the field annotation with udpateWrapper or the global config FieldStrategy? Because if you just configure a field separately, it may be a hidden logic. WDYT? cc @ruanwenjun
i think that the global config FieldStratrgy should be better, but we need review all MybatisPlus updateById to make sure that the FiledStrategy.IGNORE can match all scenes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1251033884
> > > > But the UI page still will show the last EndTime, but re-run still running, not finish. So i think that we need to make sure that setEndTime(null) can take affect
> > >
> > >
> > > OK, but can we replace the field annotation with udpateWrapper or the global config FieldStrategy? Because if you just configure a field separately, it may be a hidden logic. WDYT? cc @ruanwenjun
> >
> >
> > i think that the global config FieldStratrgy should be better, but we need review all MybatisPlus updateById to make sure that the FiledStrategy.IGNORE can match all scenes
>
> It's not a good idea to use the `strategy` from MybatisPlus, we may use another ORM in the future.
+1 I also think MP is not suitable for enterprise projects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1264970989
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11693)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_coverage&view=list) [60.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1264979080
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/11693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11693](https://codecov.io/gh/apache/dolphinscheduler/pull/11693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41885c8) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/6fc209ab9db3081f68ffef0cca874d6c44114e0c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6fc209a) will **increase** coverage by `0.00%`.
> The diff coverage is `60.00%`.
```diff
@@ Coverage Diff @@
## dev #11693 +/- ##
=========================================
Coverage 39.70% 39.71%
+ Complexity 4193 4191 -2
=========================================
Files 1016 1016
Lines 38049 38057 +8
Branches 4363 4369 +6
=========================================
+ Hits 15109 15114 +5
Misses 21195 21195
- Partials 1745 1748 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/11693?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...r/api/service/impl/ProcessInstanceServiceImpl.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9jZXNzSW5zdGFuY2VTZXJ2aWNlSW1wbC5qYXZh) | `57.37% <50.00%> (-0.34%)` | :arrow_down: |
| [...pache/dolphinscheduler/common/utils/DateUtils.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0RhdGVVdGlscy5qYXZh) | `74.39% <100.00%> (+0.31%)` | :arrow_up: |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [...r/plugin/task/sqoop/parameter/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stc3Fvb3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svc3Fvb3AvcGFyYW1ldGVyL1Nxb29wUGFyYW1ldGVycy5qYXZh) | `55.12% <0.00%> (-1.29%)` | :arrow_down: |
| [...erver/master/processor/queue/TaskEventService.java](https://codecov.io/gh/apache/dolphinscheduler/pull/11693/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9wcm9jZXNzb3IvcXVldWUvVGFza0V2ZW50U2VydmljZS5qYXZh) | `80.35% <0.00%> (+5.35%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1242592972
> Hi @DarkAssassinator I think you can use the `restartTime` field in processInstance to calculate the duration when restart. WDYT?
Hi @caishunfeng happy mid-Autumn Festival. The following change can make sure the duration value.
But the UI page still will show the last EndTime, but re-run still running, not finish. So i think that we need to make sure that setEndTime(null) can take affect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1250441968
> > > But the UI page still will show the last EndTime, but re-run still running, not finish. So i think that we need to make sure that setEndTime(null) can take affect
> >
> >
> > OK, but can we replace the field annotation with udpateWrapper or the global config FieldStrategy? Because if you just configure a field separately, it may be a hidden logic. WDYT? cc @ruanwenjun
>
> i think that the global config FieldStratrgy should be better, but we need review all MybatisPlus updateById to make sure that the FiledStrategy.IGNORE can match all scenes
It's not a good idea to use the `strategy` from MybatisPlus, we may use another ERM in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1244760372
> But the UI page still will show the last EndTime, but re-run still running, not finish. So i think that we need to make sure that setEndTime(null) can take affect
OK, but can we replace the field annotation with udpateWrapper or the global config FieldStrategy? Because if you just configure a field separately, it may be a hidden logic. WDYT? cc @ruanwenjun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#discussion_r963572178
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessInstance.java:
##########
@@ -77,6 +74,7 @@ public class ProcessInstance {
/**
* end time
*/
+ @TableField(updateStrategy = FieldStrategy.IGNORED)
Review Comment:
Please don't use this way, because it's a hide way for upper callers, will cause other problems if users don't know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on code in PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#discussion_r963865925
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/ProcessInstance.java:
##########
@@ -77,6 +74,7 @@ public class ProcessInstance {
/**
* end time
*/
+ @TableField(updateStrategy = FieldStrategy.IGNORED)
Review Comment:
emm, but also we cannot config the global field-strategy, may we can add a update sql in mapper.xml?
Or just update the date to 1970, but need change many files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11693: [Fix-#11669][Workflow Instance Page] Fix the duration and EndTime in Workflow Instance page.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11693:
URL: https://github.com/apache/dolphinscheduler/pull/11693#issuecomment-1264978541
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11693)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11693&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_coverage&view=list) [55.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11693&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org