You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jim Kellerman (JIRA)" <ji...@apache.org> on 2009/01/27 04:08:59 UTC

[jira] Created: (HBASE-1158) Include start code as part of HServerAddress

Include start code as part of HServerAddress
--------------------------------------------

                 Key: HBASE-1158
                 URL: https://issues.apache.org/jira/browse/HBASE-1158
             Project: Hadoop HBase
          Issue Type: Sub-task
    Affects Versions: 0.20.0
            Reporter: Jim Kellerman
            Assignee: Jim Kellerman
             Fix For: 0.20.0


If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.

With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1158) Include start code as part of HServerAddress

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman updated HBASE-1158:
---------------------------------

    Issue Type: Improvement  (was: Bug)

> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1158) Include start code as part of HServerAddress

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667572#action_12667572 ] 

Jim Kellerman commented on HBASE-1158:
--------------------------------------

Why is this blocked by HBASE-546? Because if we did it sooner, it would require a HBase meta region migration script.
There is no point in writing this stuff to HDFS if ZK can keep track of it


> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1158) Include start code as part of HServerAddress

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667583#action_12667583 ] 

stack commented on HBASE-1158:
------------------------------

Do you think startcode belongs in HServerAddress?  Seems like a pollution of a clean type?  Could it be carried otherwise?

> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1158) Include start code as part of HServerAddress

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667741#action_12667741 ] 

stack commented on HBASE-1158:
------------------------------

Yeah, HServerInfo sounds like a better place for the startcode.

> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1158) Include start code as part of HServerAddress

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman updated HBASE-1158:
---------------------------------

    Issue Type: Bug  (was: Sub-task)
        Parent:     (was: HBASE-1157)

> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1158) Include start code as part of HServerAddress

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman resolved HBASE-1158.
----------------------------------

    Resolution: Won't Fix

We do store the start code in the meta regions so adding it to HServerAddress is not necessary.

> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-1158) Include start code as part of HServerAddress

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman reassigned HBASE-1158:
------------------------------------

    Assignee:     (was: Jim Kellerman)

> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1158) Include start code as part of HServerAddress

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667743#action_12667743 ] 

Jim Kellerman commented on HBASE-1158:
--------------------------------------

So long as we keep track of start code somehow, then I am ok with not putting it in HServerAddress.

> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Improvement
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1158) Include start code as part of HServerAddress

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667574#action_12667574 ] 

Jim Kellerman commented on HBASE-1158:
--------------------------------------

While I would like to include the start code as a part of the HServerAddress sooner rather than later, I cannot justify a temporary migration of the ROOT and META tables to accomodate this change. Migrating data in files is hard. Using ZK these changes should be much easier.



> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1158) Include start code as part of HServerAddress

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667716#action_12667716 ] 

Jim Kellerman commented on HBASE-1158:
--------------------------------------

The start code needs to be associated with the address in some manner for server death recovery (see HBASE-1156). Whether it is carried around with the HServerAddress or not is really more a consideration for ZK than anything else. Inside the master we currently pass around HServerInfo's which carry both the start code and the load information (although one could make a case to separate the load from HServerInfo as well, since the master manipulates load information separately from the address and start code)

> Include start code as part of HServerAddress
> --------------------------------------------
>
>                 Key: HBASE-1158
>                 URL: https://issues.apache.org/jira/browse/HBASE-1158
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.20.0
>            Reporter: Jim Kellerman
>            Assignee: Jim Kellerman
>             Fix For: 0.20.0
>
>
> If we do not take the startcode into consideration when recovering from a server death, then we cannot know if the data in ROOT or META pertains to the the current instance or the previous one.
> With ZK this should be easier if we modify HServerAddress to contain the startCode of a HRegionServer instance. It would be immediately visible whether or not the region was on the dead server or the new server.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.