Proposed ImageReader patch

[george georgovassilis <ge...@open.gr>]

Dear All

I was thinking of changing the org.apache.cocoon.reading.ImageReader 
(from the 2.1.5.1 release) to accept any input image type supported by 
the j2se. Of course, due to the lack of available encoders the output is 
still jpeg. I'm attaching the source to this email, if you're happy with 
it let me know so I can commit it to bugzilla.

comments/advice welcome
G.

Re: Proposed ImageReader patch

[Torsten Curdt <tc...@apache.org>]

> let's not make a fuzz of it :-)

no fuzz ...but in order to
review the patch we expect
a diff -u as stated on the
website ...that's all I was
saying. not sure what this
has to do with impatience
as you were implying.

Just file to bugzilla whenever
you want and we will review
it whenever we want ;-)

cheers
--
Torsten

Re: Proposed ImageReader patch

[george georgovassilis <ge...@open.gr>]

Dear All

let's not make a fuzz of it :-)
I'm new to this whole procedure of committing, patching etc. In the 
committers tips it advises 'patience', so please be patient even if it 
takes me a few days (given that I'm quite busy today and our network 
link is really nerve-testing) to create the patch and commit it. I 
promise that I'll do it, just give me time to do it the right way.

Best Regards
G.

Torsten Curdt wrote:

>> i have already this patch file (diff), so i can add the patch in 
>> bugzilla for you, if you dont mind.
>
>
> the file you posted wasn't a diff.
>
> cheers
> -- 
> Torsten
>
>

Re: Proposed ImageReader patch

[Torsten Curdt <tc...@apache.org>]

> i have already this patch file (diff), so i can add the patch in bugzilla 
> for you, if you dont mind.

the file you posted wasn't a diff.

cheers
--
Torsten

Re: Proposed ImageReader patch

[go...@osmosis.gr]

On Wed, 8 Dec 2004, Torsten Curdt wrote:
hi george

i have already this patch file (diff), so i can add the patch in bugzilla 
for you, if you dont mind.


--stavros 


> george georgovassilis wrote:
> > Dear All
> > 
> > I was thinking of changing the org.apache.cocoon.reading.ImageReader 
> > (from the 2.1.5.1 release) to accept any input image type supported by 
> > the j2se. Of course, due to the lack of available encoders the output is 
> > still jpeg. I'm attaching the source to this email, if you're happy with 
> > it let me know so I can commit it to bugzilla.
> 
> please create a diff -u patch and file it to bugzilla
> 
> thanks
> --
> Torsten
> 

Re: Proposed ImageReader patch

[Torsten Curdt <tc...@apache.org>]

george georgovassilis wrote:
> Dear All
> 
> I was thinking of changing the org.apache.cocoon.reading.ImageReader 
> (from the 2.1.5.1 release) to accept any input image type supported by 
> the j2se. Of course, due to the lack of available encoders the output is 
> still jpeg. I'm attaching the source to this email, if you're happy with 
> it let me know so I can commit it to bugzilla.

please create a diff -u patch and file it to bugzilla

thanks
--
Torsten

Re: Proposed ImageReader patch

[Niclas Hedhman <ni...@hedhman.org>]

On Wednesday 08 December 2004 17:40, george georgovassilis wrote:
> Dear All
>
> I was thinking of changing the org.apache.cocoon.reading.ImageReader
> (from the 2.1.5.1 release) to accept any input image type supported by
> the j2se. Of course, due to the lack of available encoders the output is
> still jpeg. I'm attaching the source to this email, if you're happy with
> it let me know so I can commit it to bugzilla.

A couple of months ago, I have actually posted a much more advanced block, 
called ImageOpReader that can replace both the old ImageReader as well as the 
proposed patch, be extended with more Image operations, and is pretty quick 
for scaling operations.
See http://issues.apache.org/bugzilla/show_bug.cgi?id=31718  for details.

Unfortunately, noone has picked this up before :o(

Cheers
Niclas
-- 
   +------//-------------------+
  / http://www.dpml.net       /
 / http://niclas.hedhman.org / 
+------//-------------------+