You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/16 02:54:18 UTC
[jira] [Commented] (TAJO-2033) Printing out query status with
progress bar in TSQL
[ https://issues.apache.org/jira/browse/TAJO-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147994#comment-15147994 ]
ASF GitHub Bot commented on TAJO-2033:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/924#discussion_r52960997
--- Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tsql/DefaultTajoCliOutputFormatter.java ---
@@ -206,4 +278,30 @@ public static String parseErrorMessage(String message) {
return message;
}
+
+ private static boolean detectRealTerminal()
--- End diff --
You seem to borrow this code from Presto. If so, you need to add a comment explicitly.
And why did you exclude comments?
> Printing out query status with progress bar in TSQL
> ---------------------------------------------------
>
> Key: TAJO-2033
> URL: https://issues.apache.org/jira/browse/TAJO-2033
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: cli
>
> Currently, TSQL print out query running progress and query running time line-by-line. To improve this UI, I adopt simple progress bar.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)