You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by davies <gi...@git.apache.org> on 2015/04/02 07:18:43 UTC
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/5324
[SPARK-6667] [PySpark] retry after timeout to accept
This is a small chance that the socket server will timed out after 3 seconds, but client had connected to it, then the Python process will hang.
This PR will retry once after timeout, it also add a timeout at client side.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davies/spark collect_hang
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5324
----
commit b838f35867edaafd95c57d5581cbb5ac15bbcdde
Author: Davies Liu <da...@databricks.com>
Date: 2015-04-02T05:15:43Z
retry after timeout
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88738373
cc @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88782202
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29587/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88819896
[Test build #29592 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29592/consoleFull) for PR 5324 at commit [`e5a51a2`](https://github.com/apache/spark/commit/e5a51a21b90eecafe0e5677a529ad12cf9a1033d).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88759230
[Test build #29589 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29589/consoleFull) for PR 5324 at commit [`7977c2f`](https://github.com/apache/spark/commit/7977c2fda6f168ac88a953f8d0dbc42817ff825b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88782152
[Test build #29587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29587/consoleFull) for PR 5324 at commit [`b838f35`](https://github.com/apache/spark/commit/b838f35867edaafd95c57d5581cbb5ac15bbcdde).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class MessageWithHeader extends AbstractReferenceCounted implements FileRegion `
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88812095
[Test build #29589 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29589/consoleFull) for PR 5324 at commit [`7977c2f`](https://github.com/apache/spark/commit/7977c2fda6f168ac88a953f8d0dbc42817ff825b).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88778174
[Test build #29592 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29592/consoleFull) for PR 5324 at commit [`e5a51a2`](https://github.com/apache/spark/commit/e5a51a21b90eecafe0e5677a529ad12cf9a1033d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88746568
After testing for a while, it seems that the retry does not work, but the timeout on client side can help:
```
15/04/01 22:42:14 WARN PythonRDD: Timed out after 4 seconds, retry once
15/04/01 22:42:14 ERROR PythonRDD: Error while sending iterator
java.net.SocketTimeoutException: Accept timed out
at java.net.PlainSocketImpl.socketAccept(Native Method)
at java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:398)
at java.net.ServerSocket.implAccept(ServerSocket.java:530)
at java.net.ServerSocket.accept(ServerSocket.java:498)
at org.apache.spark.api.python.PythonRDD$$anon$2.run(PythonRDD.scala:624)
**********************************************************************
File "/Users/davies/work/spark/python/pyspark/rdd.py", line 1090, in __main__.RDD.variance
Failed example:
sc.parallelize([1, 2, 3]).variance()
Exception raised:
Traceback (most recent call last):
File "//anaconda/lib/python2.7/doctest.py", line 1315, in __run
compileflags, 1) in test.globs
File "<doctest __main__.RDD.variance[0]>", line 1, in <module>
sc.parallelize([1, 2, 3]).variance()
File "/Users/davies/work/spark/python/pyspark/rdd.py", line 1093, in variance
return self.stats().variance()
File "/Users/davies/work/spark/python/pyspark/rdd.py", line 948, in stats
return self.mapPartitions(lambda i: [StatCounter(i)]).reduce(redFunc)
File "/Users/davies/work/spark/python/pyspark/rdd.py", line 745, in reduce
vals = self.mapPartitions(func).collect()
File "/Users/davies/work/spark/python/pyspark/rdd.py", line 720, in collect
return list(_load_from_socket(port, self._jrdd_deserializer))
File "/Users/davies/work/spark/python/pyspark/rdd.py", line 120, in _load_from_socket
for item in serializer.load_stream(rf):
File "/Users/davies/work/spark/python/pyspark/serializers.py", line 131, in load_stream
yield self._read_with_length(stream)
File "/Users/davies/work/spark/python/pyspark/serializers.py", line 148, in _read_with_length
length = read_int(stream)
File "/Users/davies/work/spark/python/pyspark/serializers.py", line 526, in read_int
length = stream.read(4)
File "//anaconda/lib/python2.7/socket.py", line 380, in read
data = self._sock.recv(left)
timeout: timed out
**********************************************************************
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88739450
[Test build #29587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29587/consoleFull) for PR 5324 at commit [`b838f35`](https://github.com/apache/spark/commit/b838f35867edaafd95c57d5581cbb5ac15bbcdde).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88819914
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29592/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] retry after timeout to ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-88812118
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29589/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] remove setReuseAddress
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6667] [PySpark] remove setReuseAddress
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5324#issuecomment-89015402
I've merged this to `master` (1.4.0), `branch-1.3` (1.3.1), and `branch-1.2` (1.2.2). Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org