You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/30 06:12:21 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3976: STM32F7 SDMMC fixes
xiaoxiang781216 commented on a change in pull request #3976:
URL: https://github.com/apache/incubator-nuttx/pull/3976#discussion_r661158522
##########
File path: arch/arm/src/stm32f7/hardware/stm32_sdmmc.h
##########
@@ -46,7 +46,7 @@
#define STM32_SDMMC_ARG_OFFSET 0x0008 /* SDMMC argument register */
#define STM32_SDMMC_CMD_OFFSET 0x000c /* SDMMC command register */
#define STM32_SDMMC_RESPCMD_OFFSET 0x0010 /* SDMMC command response register */
-#define STM32_SDMMC_RESP_OFFSET(n) (0x0010+4*(n))
+#define STM32_SDMMC_RESP_OFFSET(n) (0x0010 + 4 * (n))
Review comment:
sqaush with the previous patch
##########
File path: arch/arm/src/stm32f7/stm32_sdmmc.c
##########
@@ -855,13 +855,9 @@ static void stm32_configwaitints(struct stm32_dev_s *priv, uint32_t waitmask,
flags = enter_critical_section();
-#ifdef CONFIG_MMCSD_SDIOWAIT_WRCOMPLETE
- if ((waitmask & SDIOWAIT_WRCOMPLETE) != 0)
+#if defined(CONFIG_MMCSD_SDIOWAIT_WRCOMPLETE)
Review comment:
don't need change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org