[GitHub] [iotdb] yschengzi commented on a change in pull request #4217: [To rel/0.12][IOTDB-1877] Fix Sync recovery and reconnection bugs in both sender and receiver

[GitBox <gi...@apache.org>]

yschengzi commented on a change in pull request #4217:
URL: https://github.com/apache/iotdb/pull/4217#discussion_r737248577



##########
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
##########
@@ -1170,6 +1170,20 @@ void setLanguageVersion(String languageVersion) {
     this.languageVersion = languageVersion;
   }
 
+  public String getIoTDBVersion() {
+    return IoTDBConstant.VERSION;
+  }
+
+  public String getIoTDBMajorVersion() {
+    return IoTDBConstant.MAJOR_VERSION;
+  }
+
+  public String getIoTDBMajorVersion(String version) {
+    return version.equals("UNKNOWN")
+        ? "UNKNOWN"
+        : version.split("\\.")[0] + "." + version.split("\\.")[1];
+  }
+

Review comment:
       i move "get major version" function from IoTDBConstant to IoTDBConfig, i think this is better to find how to get major version




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org