You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "tengu-alt (via GitHub)" <gi...@apache.org> on 2025/02/12 10:48:52 UTC

[PR] User API doc enhancement [cassandra-gocql-driver]

tengu-alt opened a new pull request, #1863:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1863

   Some of the user-exposed API is not documented which can cause misuse. This PR provides doc update fo the public methods and interfaces. 
   Fix for the #1601 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSGO-55 - User API doc enhancement [cassandra-gocql-driver]

Posted by "tengu-alt (via GitHub)" <gi...@apache.org>.
tengu-alt commented on PR #1863:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1863#issuecomment-2753663886

   Sorry for that, I've accidentally pushed without changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSGO-55 - User API doc enhancement [cassandra-gocql-driver]

Posted by "tengu-alt (via GitHub)" <gi...@apache.org>.
tengu-alt closed pull request #1863: CASSGO-55 - User API doc enhancement
URL: https://github.com/apache/cassandra-gocql-driver/pull/1863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSGO-55 - User API doc enhancement [cassandra-gocql-driver]

Posted by "tengu-alt (via GitHub)" <gi...@apache.org>.
tengu-alt commented on code in PR #1863:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1863#discussion_r2013665850


##########
filters.go:
##########
@@ -61,12 +62,6 @@ func DataCenterHostFilter(dataCenter string) HostFilter {
 	})
 }
 
-// Deprecated: Use DataCenterHostFilter instead.
-// DataCentreHostFilter is an alias that doesn't use the preferred spelling.
-func DataCentreHostFilter(dataCenter string) HostFilter {

Review Comment:
   Got it, I have returned it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSGO-55 - User API doc enhancement [cassandra-gocql-driver]

Posted by "joao-r-reis (via GitHub)" <gi...@apache.org>.
joao-r-reis commented on code in PR #1863:
URL: https://github.com/apache/cassandra-gocql-driver/pull/1863#discussion_r2012645475


##########
filters.go:
##########
@@ -61,12 +62,6 @@ func DataCenterHostFilter(dataCenter string) HostFilter {
 	})
 }
 
-// Deprecated: Use DataCenterHostFilter instead.
-// DataCentreHostFilter is an alias that doesn't use the preferred spelling.
-func DataCentreHostFilter(dataCenter string) HostFilter {

Review Comment:
   This was deprecated very recently for the 2.0 release, we don't want to remove it now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org