Re: [Patch mp2] $r->document_root($new_root)

[Geoffrey Young <ge...@modperlcookbook.org>]

> Don't
> forget to make an outstanding note to avoid using that feature (set) in
> any CPAN modules... 

that's a bit strong I think.  but a CPAN module that _does_ use this feature
should do something like

  die "sorry, this module doesn't work with threaded MPMs"
    if Apache::MPM->is_threaded;

at module load.

--Geoff

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org

Re: [Patch mp2] $r->document_root($new_root)

[Stas Bekman <st...@stason.org>]

Geoffrey Young wrote:
>>Don't
>>forget to make an outstanding note to avoid using that feature (set) in
>>any CPAN modules... 
> 
> 
> that's a bit strong I think.  but a CPAN module that _does_ use this feature
> should do something like
> 
>   die "sorry, this module doesn't work with threaded MPMs"
>     if Apache::MPM->is_threaded;
> 
> at module load.

Sure, that works for me (+use):

use Apache::MPM;
die "sorry, this module doesn't work with threaded MPMs"
     if Apache::MPM->is_threaded;

I had an idea to write one section, explaining that, and point all those 
methods to that section. But on the other hand I think most people will 
simply miss the message if it's not right there, next to the definition of 
the method.


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org