You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Geoffrey Young <ge...@modperlcookbook.org> on 2008/05/30 22:43:04 UTC
[Fwd: [rt.cpan.org #36305] Overridden get_basic_credentials broken
w/ NTLM Authentication]
-------- Original Message --------
Subject: [rt.cpan.org #36305] Overridden get_basic_credentials broken w/
NTLM Authentication
Date: Fri, 30 May 2008 13:43:17 -0400
From: RFRANKEL via RT <bu...@rt.cpan.org>
Reply-To: bug-Apache-Test@rt.cpan.org
To: undisclosed-recipients:;
References: <RT...@rt.cpan.org>
Fri May 30 13:43:16 2008: Request 36305 was acted upon.
Transaction: Ticket created by RFRANKEL
Queue: Apache-Test
Subject: Overridden get_basic_credentials broken w/ NTLM
Authentication
Broken in: 1.29, 1.30
Severity: Important
Owner: Nobody
Requestors: RFRANKEL@cpan.org
Status: new
Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=36305 >
Apache::TestRequest::get_basic_credentials dies when accessing a realm
using mod_ntlm for authentication. The reason is that $realm is undefined.
Patch to fix below:
--- TestRequest.pm~ 2007-11-14 01:44:36.000000000 -0500
+++ TestRequest.pm 2008-05-30 11:35:57.681722000 -0400
@@ -260,7 +260,7 @@
my($self, $realm, $uri, $proxy) = @_;
for ($realm, '__ALL__') {
- next unless $credentials{$_};
+ next unless $_ && $credentials{$_};
return @{ $credentials{$_} };
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [Fwd: [rt.cpan.org #36305] Overridden get_basic_credentials broken
w/ NTLM Authentication]
Posted by Fred Moyer <fr...@redhotpenguin.com>.
Reviewed, tested, and committed.
r661903
Geoffrey Young wrote:
>
>
> -------- Original Message --------
> Subject: [rt.cpan.org #36305] Overridden get_basic_credentials broken w/
> NTLM Authentication
> Date: Fri, 30 May 2008 13:43:17 -0400
> From: RFRANKEL via RT <bu...@rt.cpan.org>
> Reply-To: bug-Apache-Test@rt.cpan.org
> To: undisclosed-recipients:;
> References: <RT...@rt.cpan.org>
>
>
> Fri May 30 13:43:16 2008: Request 36305 was acted upon.
> Transaction: Ticket created by RFRANKEL
> Queue: Apache-Test
> Subject: Overridden get_basic_credentials broken w/ NTLM
> Authentication
> Broken in: 1.29, 1.30
> Severity: Important
> Owner: Nobody
> Requestors: RFRANKEL@cpan.org
> Status: new
> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=36305 >
>
>
> Apache::TestRequest::get_basic_credentials dies when accessing a realm
> using mod_ntlm for authentication. The reason is that $realm is undefined.
>
> Patch to fix below:
>
> --- TestRequest.pm~ 2007-11-14 01:44:36.000000000 -0500
> +++ TestRequest.pm 2008-05-30 11:35:57.681722000 -0400
> @@ -260,7 +260,7 @@
> my($self, $realm, $uri, $proxy) = @_;
>
> for ($realm, '__ALL__') {
> - next unless $credentials{$_};
> + next unless $_ && $credentials{$_};
> return @{ $credentials{$_} };
> }
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org