You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ivan Zhakov <iv...@visualsvn.com> on 2012/09/10 21:52:37 UTC
Re: svn commit: r1382990 - in /subversion/trunk/subversion: include/
libsvn_subr/ tests/cmdline/ tests/cmdline/getopt_tests_data/
On Mon, Sep 10, 2012 at 9:19 PM, <br...@apache.org> wrote:
> Author: brane
> Date: Mon Sep 10 17:19:31 2012
> New Revision: 1382990
>
> URL: http://svn.apache.org/viewvc?rev=1382990&view=rev
> Log:
> Make the extended version info retrieval a public API.
>
[...]
> + *
> + * @since New in 1.8.
> + */
> +typedef struct svn_version_extended_t
> +{
> + const char *version_number; /**< Version number */
> + const char *version_string; /**< Version string */
> + const char *build_date; /**< Compilation date */
> + const char *build_time; /**< Compilation time */
> + const char *build_host; /**< Build canonical host name */
Hi, Branko.
What's is the purpose of build_host?
I think it's not good idea to include build host information in
svn.exe. It could leak private or corporate network details to public.
--
Ivan Zhakov
Re: svn commit: r1382990 - in /subversion/trunk/subversion: include/
libsvn_subr/ tests/cmdline/ tests/cmdline/getopt_tests_data/
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On Tue, Sep 11, 2012 at 12:05 AM, Branko Čibej <br...@wandisco.com> wrote:
> On 10.09.2012 21:52, Ivan Zhakov wrote:
>> On Mon, Sep 10, 2012 at 9:19 PM, <br...@apache.org> wrote:
>>> Author: brane
>>> Date: Mon Sep 10 17:19:31 2012
>>> New Revision: 1382990
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1382990&view=rev
>>> Log:
>>> Make the extended version info retrieval a public API.
>>>
>> [...]
>>> + *
>>> + * @since New in 1.8.
>>> + */
>>> +typedef struct svn_version_extended_t
>>> +{
>>> + const char *version_number; /**< Version number */
>>> + const char *version_string; /**< Version string */
>>> + const char *build_date; /**< Compilation date */
>>> + const char *build_time; /**< Compilation time */
>>> + const char *build_host; /**< Build canonical host name */
>> Hi, Branko.
>>
>> What's is the purpose of build_host?
>>
>> I think it's not good idea to include build host information in
>> svn.exe. It could leak private or corporate network details to public.
>
> That string looks like the output of the config.guess script:
>
> brane@zulu:~/src/svn/repos/trunk$ ./build/config.guess
> i386-apple-darwin11.4.0
>
> In other words, it does not contain the hostname. :)
>
Cool,
May be rename it to host_type to prevent confusion?
--
Ivan Zhakov
Re: svn commit: r1382990 - in /subversion/trunk/subversion: include/
libsvn_subr/ tests/cmdline/ tests/cmdline/getopt_tests_data/
Posted by Branko Čibej <br...@wandisco.com>.
On 10.09.2012 21:52, Ivan Zhakov wrote:
> On Mon, Sep 10, 2012 at 9:19 PM, <br...@apache.org> wrote:
>> Author: brane
>> Date: Mon Sep 10 17:19:31 2012
>> New Revision: 1382990
>>
>> URL: http://svn.apache.org/viewvc?rev=1382990&view=rev
>> Log:
>> Make the extended version info retrieval a public API.
>>
> [...]
>> + *
>> + * @since New in 1.8.
>> + */
>> +typedef struct svn_version_extended_t
>> +{
>> + const char *version_number; /**< Version number */
>> + const char *version_string; /**< Version string */
>> + const char *build_date; /**< Compilation date */
>> + const char *build_time; /**< Compilation time */
>> + const char *build_host; /**< Build canonical host name */
> Hi, Branko.
>
> What's is the purpose of build_host?
>
> I think it's not good idea to include build host information in
> svn.exe. It could leak private or corporate network details to public.
That string looks like the output of the config.guess script:
brane@zulu:~/src/svn/repos/trunk$ ./build/config.guess
i386-apple-darwin11.4.0
In other words, it does not contain the hostname. :)
-- Brane
--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download