You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "akashchamp (via GitHub)" <gi...@apache.org> on 2026/09/12 00:20:41 UTC

[PR] Preserve check-buildplan failures [maven-artifact-plugin]

akashchamp opened a new pull request, #255:
URL: https://github.com/apache/maven-artifact-plugin/pull/255

   Closes #241
   
   ## What and why
   `check-buildplan` records reproducibility problems while it walks plugin executions, then checks dependency version ranges. Assigning the range result to `fail` overwrote an earlier plugin or output-timestamp failure. Preserve the existing state while still evaluating the range check so every detected reproducibility problem produces the configured failure.
   
   The existing dependency-management no-fail fixture now sets an output timestamp so it remains focused on its range-policy behavior rather than the independent timestamp check.
   
   ## Validation
   - Added an Invoker regression fixture with `maven-jar-plugin:3.1.0` and a configured output timestamp.
   - Manually reproduced the defect: the base plugin logged the non-reproducible plugin but exited `0`; the patched plugin logged the same diagnostic and exited `1` with the final failure.
   - Focused `mvn -B -Prun-its verify -Dinvoker.test=check-buildplan-plugin-fail`
   - `mvn -B verify`
   - Full `mvn -B -Prun-its verify` (17/17 scenarios)
   
   ## Checklist
   - [x] This pull request addresses one issue.
   - [x] The description explains what changes, how, and why.
   - [x] The commit has a meaningful subject and body.
   - [x] Added behavioral integration coverage.
   - [x] Ran `mvn verify`.
   - [x] Ran `mvn -Prun-its verify`.
   - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Preserve check-buildplan failures [maven-artifact-plugin]

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #255:
URL: https://github.com/apache/maven-artifact-plugin/pull/255


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Preserve check-buildplan failures [maven-artifact-plugin]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #255:
URL: https://github.com/apache/maven-artifact-plugin/pull/255#issuecomment-6233717895

   @elharo Please assign appropriate label to PR according to the type of change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org