[jira] [Commented] (THRIFT-3657) D TFileWriterTransport close should use non-priority send

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270694#comment-15270694 ] 

ASF GitHub Bot commented on THRIFT-3657:
----------------------------------------

Github user matyapiro31 commented on the pull request:

    https://github.com/apache/thrift/pull/884#issuecomment-216880297
  
    I think the change on Dockerfile must be irrelevant to version  updating of debian/ubuntu package.


> D TFileWriterTransport close should use non-priority send
> ---------------------------------------------------------
>
>                 Key: THRIFT-3657
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3657
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Library
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>            Priority: Trivial
>
> prioritySend is used in TFileWriterTransport close method.
> A possible problem with this is that even synchronized calls that are strictly before close call can be ignored in rare occasions.
> The author has put a comment "FIXME: Should use normal send here" and there's no reason not to.
> I suspect it is a remnant of old implementation or local debug stuff.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)