[jira] [Commented] (TINKERPOP3-714) Exclude jsr305 jar in assemblies to prevent jsr305 cc license from appearing in distribution

["David Robinson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615327#comment-14615327 ] 

David Robinson commented on TINKERPOP3-714:
-------------------------------------------

Hi,

I completed Giraph testing with the JSR305 patch in place with the following results:
The environment includes a hand installed Zookeeper, tinkerpop3-r2 with the jsr305 "fix" in place, Giraph 1.2.0-Snaphot (I think), Hadoop 1.2.1.

Gremlin shell start looks like this:
 bin/gremlin.sh

         \,,,/
         (o o)
-----oOOo-(3)-oOOo-----
plugin activated: tinkerpop.server
plugin activated: tinkerpop.utilities
INFO  org.apache.tinkerpop.gremlin.hadoop.structure.HadoopGraph  - HADOOP_GREMLIN_LIBS is set to: ./tinkerpop3/incubator-tinkerpop/gremlin-console/target/apache-gremlin-console-3.0.0-SNAPSHOT/ext/hadoop-gremlin/lib
plugin activated: tinkerpop.hadoop
plugin activated: tinkerpop.tinkergraph

Creating the graph looks like this (the "modern" graph is used"):
gremlin> graph=GraphFactory.open('./tinkerpop3/incubator-tinkerpop/gremlin-console/target/apache-gremlin-console-3.0.0-SNAPSHOT/conf/hadoop/hadoop-gryo.properties') 
==>hadoopgraph[gryoinputformat->gryooutputformat]
gremlin> g=graph.traversal(computer(GiraphGraphComputer))
==>graphtraversalsource[hadoopgraph[gryoinputformat->gryooutputformat], giraphgraphcomputer]

Here is the output from two Giraph based OLAP traversals:

gremlin> g.V().count()
INFO  org.apache.tinkerpop.gremlin.hadoop.process.computer.giraph.GiraphGraphComputer  - HadoopGremlin(Giraph): TraversalVertexProgram[GraphStep([],vertex), CountGlobalStep, ComputerResultStep]
INFO  org.apache.hadoop.mapred.JobClient  - Running job: job_201507061153_0001
INFO  org.apache.hadoop.mapred.JobClient  -  map 0% reduce 0%
INFO  org.apache.hadoop.mapred.JobClient  -  map 100% reduce 0%
....
INFO  org.apache.hadoop.mapred.JobClient  -  map 100% reduce 100%
......
INFO  org.apache.hadoop.mapred.JobClient  -     Total time spent by all maps waiting after reserving slots (ms)=0
INFO  org.apache.hadoop.mapred.JobClient  -     Data-local map tasks=2
INFO  org.apache.hadoop.mapred.JobClient  -   File Output Format Counters 
INFO  org.apache.hadoop.mapred.JobClient  -     Bytes Written=214
==>6

gremlin> g.V().out().out().values('name')
INFO  org.apache.tinkerpop.gremlin.hadoop.process.computer.giraph.GiraphGraphComputer  - HadoopGremlin(Giraph): TraversalVertexProgram[GraphStep([],vertex), VertexStep(OUT,vertex), VertexStep(OUT,vertex), PropertiesStep([name],value), ComputerResultStep]
INFO  org.apache.hadoop.mapred.JobClient  - Running job: job_201507061153_0003
INFO  org.apache.hadoop.mapred.JobClient  -  map 0% reduce 0%
INFO  org.apache.hadoop.mapred.JobClient  -  map 33% reduce 0%
INFO  org.apache.hadoop.mapred.JobClient  -  map 66% reduce 0%
INFO  org.apache.hadoop.mapred.JobClient  -  map 100% reduce 0%
....
INFO  org.apache.hadoop.mapred.JobClient  -     Total time spent by all maps waiting after reserving slots (ms)=0
INFO  org.apache.hadoop.mapred.JobClient  -     Data-local map tasks=2
INFO  org.apache.hadoop.mapred.JobClient  -   File Output Format Counters 
INFO  org.apache.hadoop.mapred.JobClient  -     Bytes Written=453
==>ripple
==>lop

3 map tasks were used, and a visual check of the Task Logs shows they are clean (no exceptions).

So this looks like it works ok with the JSR305 patch in place.





> Exclude jsr305 jar in assemblies to prevent jsr305 cc license from appearing in distribution
> --------------------------------------------------------------------------------------------
>
>                 Key: TINKERPOP3-714
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-714
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: build-release
>         Environment: all builds
>            Reporter: David Robinson
>            Assignee: stephen mallette
>              Labels: build
>             Fix For: 3.0.0.GA
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> jsr305 is licensed under the creative commons license and is packaged currently in the hadoop-gremlin-3.0.0-SNAPSHOT-job.jar and the standalone directory.  It also isn't needed since it is a build time static checker.
> Change the assembly xmls to exclude the inclusion of jsr305.
> A pull request will be submitted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)