You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Devgrapher <gi...@git.apache.org> on 2017/08/15 07:33:43 UTC
[GitHub] zeppelin pull request #2534: [ZEPPELIN-2859] Use es6 promise in interpreter....
GitHub user Devgrapher opened a pull request:
https://github.com/apache/zeppelin/pull/2534
[ZEPPELIN-2859] Use es6 promise in interpreter.controller
### What is this PR for?
Replace old angular callbacks with ES6 Promise callbacks.
### What type of PR is it?
Improvement
### Todos
More of the same works in the rest of the codebase needed.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2859
### How should this be tested?
Open the page `/interpreter` and see if it lists interpreters and editing them works correctly.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Devgrapher/zeppelin feature/pycon_sprint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2534
----
commit a5f3a8cd6b1825f28d13ce6a189be6c46ad507d1
Author: Brent Kim <de...@gmail.com>
Date: 2017-08-15T07:10:43Z
Use es6 promise in interpreter.controller
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2534: [ZEPPELIN-2859] Use es6 promise in interpreter....
Posted by Devgrapher <gi...@git.apache.org>.
GitHub user Devgrapher reopened a pull request:
https://github.com/apache/zeppelin/pull/2534
[ZEPPELIN-2859] Use es6 promise in interpreter.controller
### What is this PR for?
Replace old angular callbacks with ES6 Promise callbacks.
### What type of PR is it?
Improvement
### Todos
More of the same works in the rest of the codebase needed.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2859
### How should this be tested?
Open the page `/interpreter` and see if it lists interpreters and editing them works correctly.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Devgrapher/zeppelin feature/pycon_sprint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2534
----
commit a5f3a8cd6b1825f28d13ce6a189be6c46ad507d1
Author: Brent Kim <de...@gmail.com>
Date: 2017-08-15T07:10:43Z
Use es6 promise in interpreter.controller
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2534: [ZEPPELIN-2859] Use es6 promise in interpreter....
Posted by Devgrapher <gi...@git.apache.org>.
Github user Devgrapher closed the pull request at:
https://github.com/apache/zeppelin/pull/2534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2534: [ZEPPELIN-2859] Use es6 promise in interpreter....
Posted by Devgrapher <gi...@git.apache.org>.
GitHub user Devgrapher reopened a pull request:
https://github.com/apache/zeppelin/pull/2534
[ZEPPELIN-2859] Use es6 promise in interpreter.controller
### What is this PR for?
Replace old angular callbacks with ES6 Promise callbacks.
### What type of PR is it?
Improvement
### Todos
More of the same works in the rest of the codebase needed.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2859
### How should this be tested?
Open the page `/interpreter` and see if it lists interpreters and editing them works correctly.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Devgrapher/zeppelin feature/pycon_sprint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2534.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2534
----
commit a5f3a8cd6b1825f28d13ce6a189be6c46ad507d1
Author: Brent Kim <de...@gmail.com>
Date: 2017-08-15T07:10:43Z
Use es6 promise in interpreter.controller
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2534: [ZEPPELIN-2859] Use es6 promise in interpreter....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2534: [ZEPPELIN-2859] Use es6 promise in interpreter....
Posted by Devgrapher <gi...@git.apache.org>.
Github user Devgrapher closed the pull request at:
https://github.com/apache/zeppelin/pull/2534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2534: [ZEPPELIN-2859] Use es6 promise in interpreter.control...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2534
Tested and it works well.
Thanks @Devgrapher for the contribution.
LGTM and merge to master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---