You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "shubham-diwakar (via GitHub)" <gi...@apache.org> on 2025/06/30 11:16:22 UTC
[PR] GCS: Add Iceberg version to UserAgent in GCS requests [iceberg]
shubham-diwakar opened a new pull request, #13428:
URL: https://github.com/apache/iceberg/pull/13428
Currently the user-agent for traffic from GCSFileIO to GCS is unknown, having an user-agent will help in analyzing and prioritizing the performance improvements for Iceberg FileIO integration with GCS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] GCS: Add Iceberg version to UserAgent in GCS requests [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #13428:
URL: https://github.com/apache/iceberg/pull/13428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] GCS: Add Iceberg version to UserAgent in GCS requests [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #13428:
URL: https://github.com/apache/iceberg/pull/13428#discussion_r2174974813
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/PrefixedStorage.java:
##########
@@ -18,19 +18,24 @@
*/
package org.apache.iceberg.gcp.gcs;
+import com.google.api.gax.rpc.FixedHeaderProvider;
import com.google.auth.oauth2.AccessToken;
import com.google.auth.oauth2.OAuth2Credentials;
import com.google.auth.oauth2.OAuth2CredentialsWithRefresh;
import com.google.cloud.NoCredentials;
import com.google.cloud.storage.Storage;
import com.google.cloud.storage.StorageOptions;
import java.util.Map;
+import org.apache.iceberg.EnvironmentContext;
import org.apache.iceberg.gcp.GCPProperties;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.base.Strings;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
import org.apache.iceberg.util.SerializableSupplier;
class PrefixedStorage implements AutoCloseable {
+ // User Agent Prefix set by the GCS client.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] GCS: Add Iceberg version to UserAgent in GCS requests [iceberg]
Posted by "shubham-diwakar (via GitHub)" <gi...@apache.org>.
shubham-diwakar commented on PR #13428:
URL: https://github.com/apache/iceberg/pull/13428#issuecomment-3018782711
Hi @nastra, this is my first commit to GCSFileIO. I saw you have been actively contributing to GCSFileIO and hence I was wondering if you could take a look at this and share your thoughts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org