You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kezhenxu94 (GitHub)" <gi...@apache.org> on 2019/03/09 09:22:35 UTC
[GitHub] [incubator-dubbo-website] kezhenxu94 opened pull request
#323: highlight stars and forks. resolve #322
## What is the purpose of the change
XXXXX
## Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo-website/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Test your code locally by running `docsite start`, and make sure it works as expected.
- [ ] Make sure no files under build directory is added.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/323 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] kezhenxu94 commented on issue
#323: highlight stars and forks. resolve #322
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
@lovepoem Sorry I thought the change is trivial and the existed stars and forks buttons indeed have problems as described in #322 , I'll revert it if required
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/323 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lovepoem commented on issue #323:
highlight stars and forks. resolve #322
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
Now a new user can't star or fork, I will revert it
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/323 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] kezhenxu94 commented on issue
#323: highlight stars and forks. resolve #322
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
@lovepoem if any further changes should be done, please let me know, thanks
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/323 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] kezhenxu94 commented on issue
#323: highlight stars and forks. resolve #322
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/323 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] kezhenxu94 closed pull request
#323: highlight stars and forks. resolve #322
Posted by "kezhenxu94 (GitHub)" <gi...@apache.org>.
[ pull request closed by kezhenxu94 ]
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/323 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-website] lovepoem commented on issue #323:
highlight stars and forks. resolve #322
Posted by "lovepoem (GitHub)" <gi...@apache.org>.
Is this change reviewed by others ?
[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/323 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org