You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/06/13 15:18:01 UTC
[commons-lang] branch master updated: simplify_if (#543)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
The following commit(s) were added to refs/heads/master by this push:
new fb2d228 simplify_if (#543)
fb2d228 is described below
commit fb2d228380eba79585099e4c5737b3e764864d0b
Author: XenoAmess <xe...@gmail.com>
AuthorDate: Sat Jun 13 23:17:52 2020 +0800
simplify_if (#543)
---
src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java | 2 +-
.../java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java b/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
index 83d0b5f..aa83496 100644
--- a/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
+++ b/src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
@@ -439,7 +439,7 @@ public abstract class ToStringStyle implements Serializable {
protected void removeLastFieldSeparator(final StringBuffer buffer) {
final int len = buffer.length();
final int sepLen = fieldSeparator.length();
- if (len > 0 && sepLen > 0 && len >= sepLen) {
+ if (sepLen > 0 && len >= sepLen) {
boolean match = true;
for (int i = 0; i < sepLen; i++) {
if (buffer.charAt(len - 1 - i) != fieldSeparator.charAt(sepLen - 1 - i)) {
diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
index 642f973..32a9f58 100644
--- a/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
+++ b/src/test/java/org/apache/commons/lang3/StringUtilsEqualsIndexOfTest.java
@@ -76,7 +76,7 @@ public class StringUtilsEqualsIndexOfTest {
@Override
public boolean equals(final Object obj) {
- if (obj == null || !(obj instanceof CustomCharSequence)) {
+ if (!(obj instanceof CustomCharSequence)) {
return false;
}
final CustomCharSequence other = (CustomCharSequence) obj;