You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Xpray <gi...@git.apache.org> on 2018/03/01 10:56:18 UTC
[GitHub] flink pull request #5608: [FLINK-8821][TableAPI && SQL] Fix BigDecimal divid...
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/5608
[FLINK-8821][TableAPI && SQL] Fix BigDecimal divide in AvgAggFunction
## What is the purpose of the change
fix BigDecimal divide issue in AvgAggFunction
## Brief change log
- *set MathContext to DecimalAvgAggFunction*
## Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
org.apache.flink.table.runtime.aggfunctions.AvgFunctionTest
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency):
no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`:
no
- The serializers:
no
- The runtime per-record code paths (performance sensitive):
no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper:
no
- The S3 file system connector:
no
## Documentation
- Does this pull request introduce a new feature?
no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Xpray/flink FLINK-8821
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5608
----
commit 6de872e7d562354f65accf6eaeb7604f46cf7352
Author: Xpray <le...@...>
Date: 2018-03-01T10:50:13Z
[FLINK-8821][TableAPI && SQL] Fix BigDecimal divide in AvgAggFunction
----
---
[GitHub] flink issue #5608: [FLINK-8821][TableAPI && SQL] Fix non-terminating decimal...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5608
Yes, I agree that division is a special in this case. Thank you @Xpray. The changes look good. Will merge...
---
[GitHub] flink issue #5608: [FLINK-8821][TableAPI && SQL] Fix non-terminating decimal...
Posted by Xpray <gi...@git.apache.org>.
Github user Xpray commented on the issue:
https://github.com/apache/flink/pull/5608
@twalthr I've updated the PR, I think the new configuration in `TableConfig` shall only be responsible for decimal division, other decimal operations should have `UNLIMITED` context.
---
[GitHub] flink pull request #5608: [FLINK-8821][TableAPI && SQL] Fix non-terminating ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5608
---