You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/03/27 13:01:04 UTC
[GitHub] [drill] cgivre commented on a change in pull request #2024:
DRILL-7641: Convert Excel Reader to use Streaming Reader
cgivre commented on a change in pull request #2024: DRILL-7641: Convert Excel Reader to use Streaming Reader
URL: https://github.com/apache/drill/pull/2024#discussion_r399246616
##########
File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -68,20 +66,18 @@
private final ExcelReaderConfig readerConfig;
- private XSSFSheet sheet;
+ private Sheet sheet;
- private XSSFWorkbook workbook;
+ private Row currentRow;
- private InputStream fsStream;
+ private Workbook workbook;
- private FormulaEvaluator evaluator;
+ private InputStream fsStream;
private ArrayList<String> excelFieldNames;
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services