You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/06 15:43:11 UTC

[GitHub] [spark] xuanyuanking opened a new pull request #27479: [MINOR][DOC] Fix document UI left menu broken

xuanyuanking opened a new pull request #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479
 
 
   ### What changes were proposed in this pull request?
   Fix the left menu broken introduced during #25459.
   
   
   ### Why are the changes needed?
   The `left-menu-wrapper` CSS reused for both ml-guide and sql-programming-guide, the before changes will break the UI.
   
   Before:
   ![image](https://user-images.githubusercontent.com/4833765/73952563-1061d800-493a-11ea-8a75-d802a1534a44.png)
   ![image](https://user-images.githubusercontent.com/4833765/73952584-18217c80-493a-11ea-85a3-ce5f9875545f.png)
   ![image](https://user-images.githubusercontent.com/4833765/73952605-21124e00-493a-11ea-8d79-24f4dfec73d9.png)
   
   
   After:
   ![image](https://user-images.githubusercontent.com/4833765/73952630-2a031f80-493a-11ea-80ff-4630801cfaf4.png)
   ![image](https://user-images.githubusercontent.com/4833765/73952652-30919700-493a-11ea-9db1-8bb4a3f913b4.png)
   ![image](https://user-images.githubusercontent.com/4833765/73952671-35eee180-493a-11ea-801b-d50c4397adf2.png)
   
   ### Does this PR introduce any user-facing change?
   Document UI change only.
   
   
   ### How was this patch tested?
   Local test, screenshot attached below.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582967207
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582967222
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22764/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582973263
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582973263
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582973278
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117999/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582967207
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] xuanyuanking commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-583218680
 
 
   Thanks for the quick review and verification.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] xuanyuanking commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
xuanyuanking commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582966383
 
 
   cc @dilipbiswal @cloud-fan

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582966565
 
 
   **[Test build #117999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117999/testReport)** for PR 27479 at commit [`e79e5db`](https://github.com/apache/spark/commit/e79e5db05e3404ec323525f2fb9248c11cdc12ea).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582973040
 
 
   **[Test build #117999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117999/testReport)** for PR 27479 at commit [`e79e5db`](https://github.com/apache/spark/commit/e79e5db05e3404ec323525f2fb9248c11cdc12ea).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582966565
 
 
   **[Test build #117999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117999/testReport)** for PR 27479 at commit [`e79e5db`](https://github.com/apache/spark/commit/e79e5db05e3404ec323525f2fb9248c11cdc12ea).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582967222
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22764/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-582973278
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117999/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27479: [MINOR][DOC] Fix document UI left menu broken
URL: https://github.com/apache/spark/pull/27479#issuecomment-583149455
 
 
   Thank you for fixing this, @xuanyuanking . 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org