[GitHub] [hadoop] tomscut commented on a diff in pull request #4201: HDFS-16547. [SBN read] Namenode in safe mode should not be transfered to observer state

[GitBox <gi...@apache.org>]

tomscut commented on code in PR #4201:
URL: https://github.com/apache/hadoop/pull/4201#discussion_r1005646465


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java:
##########
@@ -1899,6 +1899,9 @@ synchronized void transitionToStandby() throws IOException {
   synchronized void transitionToObserver() throws IOException {
     String operationName = "transitionToObserver";
     namesystem.checkSuperuserPrivilege(operationName);
+    if (notBecomeActiveInSafemode && isInSafeMode()) {

Review Comment:
   Hi @ZanderXu , @xkrogen mentioned earlier that this parameter is used for guard and document this new behavior. What do you think of this?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org