[jira] [Work logged] (ARTEMIS-4106) Do not set property with empty key name when converting to OpenWire

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-4106?focusedWorklogId=830938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830938 ]

ASF GitHub Bot logged work on ARTEMIS-4106:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Dec/22 05:18
            Start Date: 05/Dec/22 05:18
    Worklog Time Spent: 10m 
      Work Description: brusdev commented on code in PR #4302:
URL: https://github.com/apache/activemq-artemis/pull/4302#discussion_r1039151340


##########
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverterTest.java:
##########
@@ -248,6 +248,7 @@ public void testBadPropertyConversion() throws Exception {
       coreMessage.putStringProperty(hdrBrokerInTime, "5678");
       coreMessage.putStringProperty(hdrCommandId, "foo");
       coreMessage.putStringProperty(hdrDroppable, "true");
+      coreMessage.putStringProperty("", "");

Review Comment:
   Maybe CORE messages also should reject empty property names as OpenWire messages:
   ```
   java.lang.IllegalArgumentException: Property name cannot be empty or null
   
   	at org.apache.activemq.command.ActiveMQMessage.setObjectProperty(ActiveMQMessage.java:497)
   	...
   ```
   
   This would also avoid the error on converting to OpenWire CORE messages with empty property names.





Issue Time Tracking
-------------------

            Worklog Id:     (was: 830938)
    Remaining Estimate: 0h
            Time Spent: 10m

> Do not set property with empty key name when converting to OpenWire
> -------------------------------------------------------------------
>
>                 Key: ARTEMIS-4106
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4106
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)