[GitHub] [knox] smolnar82 commented on a change in pull request #263: [WIP] KNOX-2226 - Add home page to Knox

[GitBox <gi...@apache.org>]

smolnar82 commented on a change in pull request #263: [WIP] KNOX-2226 - Add home page to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r378900910
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java
 ##########
 @@ -923,6 +925,40 @@ private synchronized void internalActivateArchive( Topology topology, File warDi
     }
   }
 
+  private synchronized void activateHomeApp() {
+    try {
+      // UI
+      activateHomepageContext("/home", "homepage/%2Fhome");
 
 Review comment:
   I've just followed the process which is already in place for dynamic topology deployment. That process also creates `%2F` and `%2Fadmin-ui` folders where necessary. When tested, it was not even working w/o these prefixes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services