[GitHub] [iceberg] samredai commented on a change in pull request #3184: [Python] setup new python library module structure.

[GitBox <gi...@apache.org>]

samredai commented on a change in pull request #3184:
URL: https://github.com/apache/iceberg/pull/3184#discussion_r717963148



##########
File path: python/setup.cfg
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[metadata]
+name = py-iceberg

Review comment:
       Would anyone be opposed to using a name without dashes, for example `pyiceberg`? Dashes create slight variance that can make a new user's experience a bit clunky. For example after installing it using `pip3 install py-iceberg` they then have to import it as `import py_iceberg`. Also when someone sees some sample code and want to jump right in, they may intuitively try `pip3 install py_iceberg` eventually finding out it should be `pip3 install py-iceberg`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org