You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jeremyje (via GitHub)" <gi...@apache.org> on 2023/04/01 00:43:37 UTC
[GitHub] [beam] jeremyje opened a new pull request, #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
jeremyje opened a new pull request, #26065:
URL: https://github.com/apache/beam/pull/26065
Fixes https://github.com/apache/beam/issues/26064
All changes are for the Go SDK.
* Add support for renaming GCS files. This is performed by a copy and then delete so it is not atomic. The Java implementation follows this approach.
* Add support for Copy in Local FileSystem.
* Add test coverage for the GCS FileSystem implementation. This adds a new test dependency to `github.com/fsouza/fake-gcs-server/fakestorage`.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [X] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [?] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1503872479
Thank you for your contribution and your patience while we got everything tested!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1503858492
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1494382111
assign to next reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey merged pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey merged PR #26065:
URL: https://github.com/apache/beam/pull/26065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jeremyje commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jeremyje (via GitHub)" <gi...@apache.org>.
jeremyje commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1501894066
Updated the `CHANGES.md` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a diff in pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on code in PR #26065:
URL: https://github.com/apache/beam/pull/26065#discussion_r1156160371
##########
sdks/go/pkg/beam/io/filesystem/gcs/gcs_test.go:
##########
@@ -36,3 +40,238 @@ func TestGCS_FilesystemNew(t *testing.T) {
t.Errorf("c.Close() = %v, want nil", err)
}
}
+
+func TestGCS_direct(t *testing.T) {
+ ctx := context.Background()
+ dirPath := "gs://beamgogcsfilesystemtest"
+ filePath := dirPath + "/file.txt"
+
+ server := fakestorage.NewServer([]fakestorage.Object{
+ {
+ ObjectAttrs: fakestorage.ObjectAttrs{
+ BucketName: "beamgogcsfilesystemtest",
+ Name: "stub",
+ },
+ Content: []byte(""),
+ },
+ })
Review Comment:
Consider refactoring the creation of the mock storage system into a helper function since this block is reused often
##########
sdks/go/pkg/beam/io/filesystem/gcs/gcs_test.go:
##########
@@ -36,3 +40,238 @@ func TestGCS_FilesystemNew(t *testing.T) {
t.Errorf("c.Close() = %v, want nil", err)
}
}
+
+func TestGCS_direct(t *testing.T) {
+ ctx := context.Background()
+ dirPath := "gs://beamgogcsfilesystemtest"
+ filePath := dirPath + "/file.txt"
+
+ server := fakestorage.NewServer([]fakestorage.Object{
+ {
+ ObjectAttrs: fakestorage.ObjectAttrs{
+ BucketName: "beamgogcsfilesystemtest",
+ Name: "stub",
+ },
+ Content: []byte(""),
+ },
+ })
+ defer server.Stop()
Review Comment:
Prefer using t.Cleanup() over defer, which lets you put the `server.Stop()` call into the helper function. See https://google.github.io/styleguide/go/decisions#test-helpers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1501808308
Run Whitespace PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1492777363
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
R: @pabloem for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jeremyje commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jeremyje (via GitHub)" <gi...@apache.org>.
jeremyje commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1503691697
Rebased with latest changes and reran `go mod tidy` since there were conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1501808098
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a diff in pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on code in PR #26065:
URL: https://github.com/apache/beam/pull/26065#discussion_r1161736274
##########
CHANGES.md:
##########
@@ -63,6 +63,7 @@
* Added HbaseIO support for writing RowMutations (ordered by rowkey) to Hbase (Java) ([#25830](https://github.com/apache/beam/issues/25830)).
* Added fileio transforms MatchFiles, MatchAll and ReadMatches (Go) ([#25779](https://github.com/apache/beam/issues/25779)).
* Add integration test for JmsIO + fix issue with multiple connections (Java) ([#25887](https://github.com/apache/beam/issues/25887)).
+* Added rename for GCS and copy for local filesystem (Go) ([#25779](https://github.com/apache/beam/issues/26064)).
Review Comment:
CHANGES.md has been updated as part of the release process, this will need to be moved to the 2.48.0 section since the 2.47 branch has been cut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1492764771
## [Codecov](https://codecov.io/gh/apache/beam/pull/26065?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26065](https://codecov.io/gh/apache/beam/pull/26065?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (98bc551) into [master](https://codecov.io/gh/apache/beam/commit/f93cb9af5312de9ef1771638be1d17586d55fa9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f93cb9a) will **increase** coverage by `0.04%`.
> The diff coverage is `53.12%`.
```diff
@@ Coverage Diff @@
## master #26065 +/- ##
==========================================
+ Coverage 71.42% 71.46% +0.04%
==========================================
Files 782 782
Lines 102848 102880 +32
==========================================
+ Hits 73456 73521 +65
+ Misses 27915 27869 -46
- Partials 1477 1490 +13
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `54.22% <53.12%> (+0.14%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/26065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/io/filesystem/gcs/gcs.go](https://codecov.io/gh/apache/beam/pull/26065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9maWxlc3lzdGVtL2djcy9nY3MuZ28=) | `59.45% <52.63%> (+47.50%)` | :arrow_up: |
| [sdks/go/pkg/beam/io/filesystem/local/local.go](https://codecov.io/gh/apache/beam/pull/26065?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9maWxlc3lzdGVtL2xvY2FsL2xvY2FsLmdv) | `59.52% <53.84%> (-2.55%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26065/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1503858216
I don't think Jenkins picked up the precommits for some reason, let me see if I can get it to run...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1501807798
Run Go PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1494385405
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label go.
R: @pabloem for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1494542026
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #26065: Go SDK: GCS FS supports rename, improved test coverage. Local FS supports copy.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #26065:
URL: https://github.com/apache/beam/pull/26065#issuecomment-1501808217
Run RAT PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org