You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2017/09/22 07:05:59 UTC

[GitHub] carbondata pull request #1378: [CARBONDATA-1509] Fixed bug for maintaining c...

GitHub user manishgupta88 opened a pull request:

    https://github.com/apache/carbondata/pull/1378

    [CARBONDATA-1509] Fixed bug for maintaining compatibility of decimal type with older releases of Carbondata

    In old Carbondata releases, precision and scale is not stored for decimal data type and both values are initialized to -1. In TableSpec.ColumnSpec  default values for precision and scale are initialized to 0 because of which exception is thrown while reading the old store with decimal column. Both precision and scale should be initialized to -1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manishgupta88/carbondata decimal_backward_compatibility

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1378
    
----
commit bd7c4787ae8e0e0baad6218c9c6e5c58cd99db91
Author: manishgupta88 <to...@gmail.com>
Date:   2017-09-22T06:52:39Z

    In old Carbondata releases, precision and scale is not stored for decimal data type and both values are initialized to -1. In TableSpec.ColumnSpec  default values for precision and scale are initialized to 0 because of which exception is thrown while reading the old store with decimal column. Both precision and scale should be initialized to -1.

----


---

[GitHub] carbondata issue #1378: [CARBONDATA-1509] Fixed bug for maintaining compatib...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1378
  
    LGTM


---

[GitHub] carbondata issue #1378: [CARBONDATA-1509] Fixed bug for maintaining compatib...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1378
  
    Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/143/



---

[GitHub] carbondata issue #1378: [CARBONDATA-1509] Fixed bug for maintaining compatib...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1378
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/267/



---

[GitHub] carbondata issue #1378: [CARBONDATA-1509] Fixed bug for maintaining compatib...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1378
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/899/



---

[GitHub] carbondata pull request #1378: [CARBONDATA-1509] Fixed bug for maintaining c...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1378


---