[GitHub] spark pull request: [SPARK-1331] Added graceful shutdown to Spark ...

[pwendell <gi...@git.apache.org>]

Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/247#discussion_r11227467
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
    @@ -158,6 +158,15 @@ class StreamingContext private[streaming] (
     
       private[streaming] val waiter = new ContextWaiter
     
    +  /** Enumeration to identify current state of the StreamingContext */
    +  private[streaming] object ContextState extends Enumeration {
    --- End diff --
    
    minor: but how would you feel about calling this `StreamingContextState`? I found it a bit confusing when looking at it directly. Then you could probably even remove the doc because it would be totally clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---