You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/05/20 20:48:34 UTC

[PR] Fix camel validate normalize command [camel]

davsclaus opened a new pull request, #23390:
URL: https://github.com/apache/camel/pull/23390

   ## Summary
   
   _Claude Code on behalf of Claus Ibsen_
   
   Fix the `camel validate normalize` command which was non-functional due to two bugs:
   
   - **`.camel.yaml` files silently skipped**: `FileUtil.onlyExt(name)` returns `camel.yaml` for double extensions — changed to `FileUtil.onlyExt(name, true)` (single-extension mode) to correctly return `yaml`. Same fix applied to `YamlValidateCommand`.
   - **Route reification failures**: The command used a lightweight CamelContext that couldn't resolve EIP implementations (CircuitBreaker needs resilience4j, etc.). Rewrote to delegate to the `Run` command with `camel.main.dumpRoutes=yaml`, following the same proven pattern used by `TransformRoute`.
   - **URI parameters as expanded key/values**: Set `dumpRoutesUriAsParameters=true` so the canonical output uses expanded `parameters:` blocks instead of inlining parameters as query strings.
   
   ## Test plan
   
   - [x] Build: `mvn install -pl dsl/camel-jbang/camel-jbang-plugin-validate -am -DskipTests -q`
   - [x] Test simple file: `camel validate normalize timer-log.camel.yaml` — produces canonical YAML with expanded parameters
   - [x] Test complex file (CircuitBreaker): `camel validate normalize route.camel.yaml` — no longer fails on missing EIP implementations
   - [x] Normalize 23 example files in camel-jbang-examples successfully
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix camel validate normalize command [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23390:
URL: https://github.com/apache/camel/pull/23390#issuecomment-4502735520

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `dsl/camel-jbang/camel-jbang-plugin-validate`
   
   :white_check_mark: **POM dependency changes: targeted tests included**
   
   <details><summary>Modules affected by dependency changes (1)</summary>
   
   - `:camel-jbang-plugin-validate`
   
   </details>
   
   <details><summary>All tested modules (2 modules)</summary>
   
   - Camel :: JBang :: Plugin :: Validate
   - Camel :: Launcher :: Container
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/26189092469)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix camel validate normalize command [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #23390:
URL: https://github.com/apache/camel/pull/23390


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix camel validate normalize command [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23390:
URL: https://github.com/apache/camel/pull/23390#issuecomment-4502591226

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org