You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/08 16:25:10 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to test RocksDB
LuciferYang opened a new pull request, #36119:
URL: https://github.com/apache/spark/pull/36119
### What changes were proposed in this pull request?
`FsHistoryProviderSuite` only test leveldb backend now, this pr divides the UTs of `FsHistoryProviderSuite` into two groups:
1. 7 test cases not related to `HybridStoreDiskBackend` were moved into `NoDiskBackendFsHistoryProviderSuite`
2. 36 test case related to `HybridStoreDiskBackend` were moved into `DiskBackendFsHistoryProviderSuite`, then add `LevelDBBackendFsHistoryProviderSuite` and `RocksDBBackendFsHistoryProviderSuite` to test different kvstore backend
### Why are the changes needed?
Add UTs related to rockdb
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846336939
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1249,7 +1316,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
log3_2.setLastModified(10L)
val provider = new FsHistoryProvider(createTestConf().set(MAX_LOG_NUM.key, s"$num"), clock)
- updateAndCheck(provider) { list =>
+ updateAndCheck(provider) { _ =>
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846568980
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
There are 7 UT will not use rocksdb and leveldb, `backwards compatibility with LogInfo from Spark 2.4` is one of them. In order to avoid duplicate testing, I moved them to `NoDiskBackendFsHistoryProviderSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846572840
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
> The 7 UT moved to NoDiskBackendFsHistoryProviderSuite include:
Sorry, it's 6 UT, not 7 UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846569419
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
The 7 UT moved to `NoDiskBackendFsHistoryProviderSuite ` include:
- Parse application logs (inMemory = true)
- backwards compatibility with LogInfo from Spark 2.4
- SPARK-29755 LogInfo should be serialized/deserialized by jackson properly
- SPARK-29755 AttemptInfoWrapper should be serialized/deserialized by jackson properly
- SPARK-33146: don't let one bad rolling log folder prevent loading other applications
- SPARK-36354: EventLogFileReader should skip rolling event log directories with no logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846706060
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
The change may as follows:
```
Index: core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala b/core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
--- a/core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala (revision b57c93b2ab5d6b86cefc8eb0ce8a01c596e0630d)
+++ b/core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala (revision 5fc7a99519182b336ba5575d7e236182410211b5)
@@ -52,11 +52,24 @@
import org.apache.spark.status.AppStatusStore
import org.apache.spark.status.KVUtils.KVStoreScalaSerializer
import org.apache.spark.status.api.v1.{ApplicationAttemptInfo, ApplicationInfo}
+import org.apache.spark.tags.ExtendedLevelDBTest
import org.apache.spark.util.{Clock, JsonProtocol, ManualClock, Utils}
import org.apache.spark.util.kvstore.InMemoryStore
import org.apache.spark.util.logging.DriverLogger
-class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
+
+@ExtendedLevelDBTest
+class LevelDBBackendFsHistoryProviderSuite extends FsHistoryProviderSuite {
+ override protected def diskBackend: HybridStoreDiskBackend.Value =
+ HybridStoreDiskBackend.LEVELDB
+}
+
+class RocksDBBackendFsHistoryProviderSuite extends FsHistoryProviderSuite {
+ override protected def diskBackend: HybridStoreDiskBackend.Value =
+ HybridStoreDiskBackend.ROCKSDB
+}
+
+abstract class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
private var testDir: File = null
override def beforeEach(): Unit = {
@@ -72,6 +85,8 @@
}
}
+ protected def diskBackend: HybridStoreDiskBackend.Value
+
/** Create a fake log file using the new log format used in Spark 1.3+ */
private def newLogFile(
appId: String,
@@ -1651,11 +1666,10 @@
.set(FAST_IN_PROGRESS_PARSING, true)
if (!inMemory) {
- // LevelDB doesn't support Apple Silicon yet
- assume(!Utils.isMacOnAppleSilicon)
conf.set(LOCAL_STORE_DIR, Utils.createTempDir().getAbsolutePath())
}
conf.set(HYBRID_STORE_ENABLED, useHybridStore)
+ conf.set(HYBRID_STORE_DISK_BACKEND.key, diskBackend.toString)
conf
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846705314
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
@dongjoon-hyun If we think this pr changed too much, I have another way:
1. Directly change `FsHistoryProviderSuite` into an abstract class without moving any UTs
2. Add subclasses `LevelDBBackendFsHistoryProviderSuite` and `RocksDBBackendFsHistoryProviderSuite` of `FsHistoryProviderSuite` to test different DiskBackend
This way should make the changes look few, but he disadvantage is the above 6 UT will be tested repeatedly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #36119:
URL: https://github.com/apache/spark/pull/36119#issuecomment-1094819835
@dongjoon-hyun I have simplified the change of the this pr, which may look clearer, although some tests will be tested twice. Cloud you help to review it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846336582
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1070,7 +1137,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
clock.advance(TimeUnit.DAYS.toMillis(2))
provider.checkForLogs()
provider.cleanLogs()
- assert(new File(testDir.toURI).listFiles().size === validLogCount)
+ assert(new File(testDir.toURI).listFiles().length === validLogCount)
Review Comment:
Actually, this is not for RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846568980
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
There are 7 UT will not use rocksdb and leveldb, `backwards compatibility with LogInfo from Spark 2.4` is one of them
. In order to avoid duplicate testing, I moved them to `NoDiskBackendFsHistoryProviderSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #36119: [SPARK-38835][CORE][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #36119: [SPARK-38835][CORE][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
URL: https://github.com/apache/spark/pull/36119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846336726
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1094,8 +1161,8 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
val provider = new FsHistoryProvider(conf)
updateAndCheck(provider) { list =>
assert(list.size === 1)
- assert(list(0).attempts.size === 1)
- assert(list(0).attempts(0).completed)
+ assert(list.head.attempts.size === 1)
+ assert(list.head.attempts.head.completed)
Review Comment:
ditto. This is irrelevant to RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846569419
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
The 7 UT moved to `NoDiskBackendFsHistoryProviderSuite ` include:
- `Parse application logs (inMemory = true)`
- `backwards compatibility with LogInfo from Spark 2.4`
- `SPARK-29755 LogInfo should be serialized/deserialized by jackson properly`
- `SPARK-29755 AttemptInfoWrapper should be serialized/deserialized by jackson properly`
- `SPARK-33146: don't let one bad rolling log folder prevent loading other applications`
- `SPARK-36354: EventLogFileReader should skip rolling event log directories with no logs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846568725
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1070,7 +1137,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
clock.advance(TimeUnit.DAYS.toMillis(2))
provider.checkForLogs()
provider.cleanLogs()
- assert(new File(testDir.toURI).listFiles().size === validLogCount)
+ assert(new File(testDir.toURI).listFiles().length === validLogCount)
Review Comment:
Sorry, Intellij automatically made code cleanup, and [12c0935](https://github.com/apache/spark/pull/36119/commits/12c09357b7f0d1bfc3b70a5f8c2f51d259a055e7) and [25e2699](https://github.com/apache/spark/pull/36119/commits/25e2699f64668f0bef6fe6c6c23f1097e5186262) revert the irrelevant changes
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1094,8 +1161,8 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
val provider = new FsHistoryProvider(conf)
updateAndCheck(provider) { list =>
assert(list.size === 1)
- assert(list(0).attempts.size === 1)
- assert(list(0).attempts(0).completed)
+ assert(list.head.attempts.size === 1)
+ assert(list.head.attempts.head.completed)
Review Comment:
done
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1249,7 +1316,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
log3_2.setLastModified(10L)
val provider = new FsHistoryProvider(createTestConf().set(MAX_LOG_NUM.key, s"$num"), clock)
- updateAndCheck(provider) { list =>
+ updateAndCheck(provider) { _ =>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846572454
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
Got it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36119: [SPARK-38835][TESTS] Refactor `FsHistoryProviderSuite` to add UTs for RocksDB
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36119:
URL: https://github.com/apache/spark/pull/36119#discussion_r846337155
##########
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala:
##########
@@ -1261,74 +1328,6 @@ class FsHistoryProviderSuite extends SparkFunSuite with Matchers with Logging {
}
}
- test("backwards compatibility with LogInfo from Spark 2.4") {
Review Comment:
May I ask whey do you move this position of this test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org