You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/24 01:16:07 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #5139:
[REFACTOR][TIR] Introduce PrimFuncPass.
tqchen opened a new pull request #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139
- Introduce PrimFuncPass
- Convert one pass to the unified Pass API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5139:
[REFACTOR][TIR] Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#discussion_r396856965
##########
File path: python/tvm/tir/transform/function_pass.py
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""TIR specific function pass support."""
+import inspect
+import functools
+
+import tvm._ffi
+from tvm.ir.transform import Pass, PassInfo
+
+from . import _ffi_api
+
+
+@tvm._ffi.register_object("tir.PrimFuncPass")
+class PrimFuncPass(Pass):
+ """A pass that works on each tvm.relay.Function in a module. A function
Review comment:
tvm.tir.PrimFunc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5139: [REFACTOR][TIR]
Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#issuecomment-603298988
Thanks @zhiics @siju-samue哈
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5139:
[REFACTOR][TIR] Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#discussion_r396857224
##########
File path: python/tvm/tir/transform/function_pass.py
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""TIR specific function pass support."""
+import inspect
+import functools
+
+import tvm._ffi
+from tvm.ir.transform import Pass, PassInfo
+
+from . import _ffi_api
+
+
+@tvm._ffi.register_object("tir.PrimFuncPass")
+class PrimFuncPass(Pass):
+ """A pass that works on each tvm.relay.Function in a module. A function
+ pass class should be created through py:func:`tvm.tir.transform.function_pass`.
+ """
+
+
+def _wrap_class_function_pass(pass_cls, pass_info):
+ """Wrap a python class as function pass"""
+ class PyFunctionPass(PrimFuncPass):
+ """Internal wrapper class to create a class instance."""
+ def __init__(self, *args, **kwargs):
+ # initialize handle in cass pass_cls creation failed.fg
+ self.handle = None
+ inst = pass_cls(*args, **kwargs)
+ # it is important not to capture self to
+ # avoid a cyclic dependency
+ def _pass_func(func, mod, ctx):
+ return inst.transform_function(func, mod, ctx)
+ self.__init_handle_by_constructor__(
+ _ffi_api.CreatePrimFuncPass, _pass_func, pass_info)
+ self._inst = inst
+
+ def __getattr__(self, name):
+ # fall back to instance attribute if there is not any
+ return self._inst.__getattribute__(name)
+
+ functools.update_wrapper(PyFunctionPass.__init__, pass_cls.__init__)
+ PyFunctionPass.__name__ = pass_cls.__name__
+ PyFunctionPass.__doc__ = pass_cls.__doc__
+ PyFunctionPass.__module__ = pass_cls.__module__
+ return PyFunctionPass
+
+
+def prim_func_pass(pass_func=None, opt_level=None, name=None, required=None):
+ """Decorate a function pass.
+
+ This function returns a callback when pass_func
+ is provided. Otherwise, it returns the created function pass using the
+ given optimization function.
+
+ Parameters
+ ----------
+ pass_func : Optional[Callable[(Function, Module, PassContext) -> Function]]
Review comment:
Function->PrimFunc
Module->IRModule
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5139:
[REFACTOR][TIR] Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#issuecomment-602947793
cc @yzhliu @kazum @vinx13 @merrymercy @Hzfengsy @ZihengJiang @wweic @zhiics @icemelon9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request
#5139: [REFACTOR][TIR] Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
siju-samuel commented on a change in pull request #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#discussion_r396869991
##########
File path: tests/python/unittest/test_tir_transform_combine_context_call.py
##########
@@ -37,9 +37,15 @@ def device_context(dev_id):
("int32", "fadd", device_context(0), A))
body = ib.get()
f = tvm.tir.ir_pass.MakeAPI(body, "func", [dev_type, n], 2, True)
- f = tvm.tir.ir_pass.CombineContextCall(f)
- assert f.body.value.dtype == "handle"
- assert f.body.body.value.dtype == "handle"
+
+ # temp adapter t convert loweredFunc to IRModule
Review comment:
t -> to?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5139: [REFACTOR][TIR]
Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#issuecomment-602947793
cc @yzhliu @kazum @vinx13 @merrymercy @Hzfengsy @ZihengJiang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request
#5139: [REFACTOR][TIR] Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
siju-samuel commented on a change in pull request #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#discussion_r396869176
##########
File path: src/tir/ir/transform.cc
##########
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tir/ir/transform.cc
+ * \brief TIR specific transformation passes.
+ */
+#include <tvm/runtime/registry.h>
+#include <tvm/node/repr_printer.h>
+#include <tvm/tir/transform.h>
+
+
+namespace tvm {
+namespace tir {
+namespace transform {
+
+
+/*!
+ * \brief Function level pass that applies transformations to all
+ * TIR functions within the module.
+ */
+class PrimFuncPassNode : public PassNode {
+ public:
+ /* \brief The pass meta data.*/
+ PassInfo pass_info;
+
+ /*! \brief The pass function called on each. */
+ runtime::TypedPackedFunc<PrimFunc(PrimFunc, IRModule, PassContext)> pass_func;
+
+ void VisitAttrs(tvm::AttrVisitor* v) {
+ v->Visit("pass_info", &pass_info);
+ }
+
+ /*!
+ * \brief Run a function pass on given pass context.
+ *
+ * \param mod The module that an optimization pass is applied on.
+ * \param mod The context that an optimization pass executes on.
Review comment:
mod -> pass_ctx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5139:
[REFACTOR][TIR] Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
zhiics commented on a change in pull request #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#discussion_r396857607
##########
File path: python/tvm/tir/transform/function_pass.py
##########
@@ -0,0 +1,149 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""TIR specific function pass support."""
+import inspect
+import functools
+
+import tvm._ffi
+from tvm.ir.transform import Pass, PassInfo
+
+from . import _ffi_api
+
+
+@tvm._ffi.register_object("tir.PrimFuncPass")
+class PrimFuncPass(Pass):
+ """A pass that works on each tvm.relay.Function in a module. A function
+ pass class should be created through py:func:`tvm.tir.transform.function_pass`.
+ """
+
+
+def _wrap_class_function_pass(pass_cls, pass_info):
+ """Wrap a python class as function pass"""
+ class PyFunctionPass(PrimFuncPass):
+ """Internal wrapper class to create a class instance."""
+ def __init__(self, *args, **kwargs):
+ # initialize handle in cass pass_cls creation failed.fg
+ self.handle = None
+ inst = pass_cls(*args, **kwargs)
+ # it is important not to capture self to
+ # avoid a cyclic dependency
+ def _pass_func(func, mod, ctx):
+ return inst.transform_function(func, mod, ctx)
+ self.__init_handle_by_constructor__(
+ _ffi_api.CreatePrimFuncPass, _pass_func, pass_info)
+ self._inst = inst
+
+ def __getattr__(self, name):
+ # fall back to instance attribute if there is not any
+ return self._inst.__getattribute__(name)
+
+ functools.update_wrapper(PyFunctionPass.__init__, pass_cls.__init__)
+ PyFunctionPass.__name__ = pass_cls.__name__
+ PyFunctionPass.__doc__ = pass_cls.__doc__
+ PyFunctionPass.__module__ = pass_cls.__module__
+ return PyFunctionPass
+
+
+def prim_func_pass(pass_func=None, opt_level=None, name=None, required=None):
+ """Decorate a function pass.
+
+ This function returns a callback when pass_func
+ is provided. Otherwise, it returns the created function pass using the
+ given optimization function.
+
+ Parameters
+ ----------
+ pass_func : Optional[Callable[(Function, Module, PassContext) -> Function]]
+ The transformation function or class.
+
+ opt_level : int
+ The optimization level of this module pass.
+
+ name : Optional[str]
+ The name of the function pass. The name could be empty. In this case, the
+ name of the optimization function will be used as the pass name.
+
+ required : Optional[List[str]]
+ The list of passes that the module pass is dependent on.
Review comment:
function pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #5139: [REFACTOR][TIR]
Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #5139:
[REFACTOR][TIR] Introduce PrimFuncPass.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #5139: [REFACTOR][TIR] Introduce PrimFuncPass.
URL: https://github.com/apache/incubator-tvm/pull/5139#issuecomment-602947793
cc @yzhliu @kazum @vinx13 @merrymercy @Hzfengsy @ZihengJiang @wweic @zhiics @icemelon9 @jroesch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services