You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 13:19:45 UTC
[GitHub] [airflow] kishvanchee opened a new pull request #11304: Move latest_only_operator.py to latest_only.py (#11178)
kishvanchee opened a new pull request #11304:
URL: https://github.com/apache/airflow/pull/11304
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This change is related to #11178 for `latest_only_operator`.
I tried running the unit test in breeze, they passed with some warnings. I'm not sure what to make of it, but if I'm supposed to be doing something please let me know.
```
root@b20475852b92:/opt/airflow# pytest tests/operators/test_latest_only_operator.py
========================================================================= test session starts =========================================================================
platform linux -- Python 3.6.12, pytest-6.0.1, py-1.9.0, pluggy-0.13.1 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: timeouts-1.2.1, forked-1.3.0, rerunfailures-9.0, requests-mock-1.8.0, flaky-3.7.0, xdist-2.0.0, cov-2.10.1, celery-4.4.7, instafail-0.4.2
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 3 items
tests/operators/test_latest_only_operator.py::TestLatestOnlyOperator::test_not_skipping_external
PASSED [ 33%]
tests/operators/test_latest_only_operator.py::TestLatestOnlyOperator::test_run PASSED [ 66%]
tests/operators/test_latest_only_operator.py::TestLatestOnlyOperator::test_skipping_non_latest PASSED [100%]
========================================================================== warnings summary ===========================================================================
tests/operators/test_latest_only_operator.py::TestLatestOnlyOperator::test_not_skipping_external
tests/operators/test_latest_only_operator.py::TestLatestOnlyOperator::test_not_skipping_external
/usr/local/lib/python3.6/site-packages/alembic/ddl/sqlite.py:41: UserWarning: Skipping unsupported ALTER for creation of implicit constraintPlease refer to the batch mode feature which allows for SQLite migrations using a copy-and-move strategy.
"Skipping unsupported ALTER for "
-- Docs: https://docs.pytest.org/en/stable/warnings.html
=================================================================== 3 passed, 2 warnings in 30.69s ====================================================================
Exception ignored in: <function _ConnectionRecord.checkout.<locals>.<lambda> at 0x7f077fd61e18>
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/pool/base.py", line 506, in <lambda>
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/pool/base.py", line 714, in _finalize_fairy
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/pool/base.py", line 531, in checkin
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/pool/base.py", line 388, in _return_conn
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/pool/impl.py", line 236, in _do_return_conn
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/pool/base.py", line 543, in close
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/pool/base.py", line 645, in __close
File "/usr/local/lib/python3.6/site-packages/sqlalchemy/pool/base.py", line 267, in _close_connection
File "/usr/local/lib/python3.6/logging/__init__.py", line 1295, in debug
File "/usr/local/lib/python3.6/logging/__init__.py", line 1548, in isEnabledFor
TypeError: '>=' not supported between instances of 'int' and 'NoneType'
```
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kishvanchee commented on pull request #11304: Move latest_only_operator.py to latest_only.py (#11178)
Posted by GitBox <gi...@apache.org>.
kishvanchee commented on pull request #11304:
URL: https://github.com/apache/airflow/pull/11304#issuecomment-704263912
@mik-laj @turbaszek please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11304: Move latest_only_operator.py to latest_only.py (#11178)
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11304:
URL: https://github.com/apache/airflow/pull/11304#issuecomment-704601891
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #11304: Move latest_only_operator.py to latest_only.py (#11178)
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #11304:
URL: https://github.com/apache/airflow/pull/11304
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org