[GitHub] [flink] JingsongLi commented on a change in pull request #13216: [FLINK-18999][table-planner-blink][hive] Temporary generic table does…

[GitBox <gi...@apache.org>]

JingsongLi commented on a change in pull request #13216:
URL: https://github.com/apache/flink/pull/13216#discussion_r502260081



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java
##########
@@ -148,11 +150,27 @@ public static DynamicTableSink createTableSink(
 			CatalogTable catalogTable,
 			ReadableConfig configuration,
 			ClassLoader classLoader) {
+		return createTableSink(catalog, objectIdentifier, catalogTable, configuration, classLoader, false);
+	}
+
+	/**
+	 * Creates a {@link DynamicTableSink} from a {@link CatalogTable}.
+	 *
+	 * <p>It considers {@link Catalog#getFactory()} if provided.
+	 */
+	public static DynamicTableSink createTableSink(

Review comment:
       Not only source, sink too.
   I can see the bug in `HiveDynamicTableFactory` because not remove old method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org