You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by Sai Krishna Kishore Beathanabhotla <be...@gmail.com> on 2015/11/09 10:57:09 UTC
METAMODEL-205 Code review
Hi,
I am very much interested in joining the metamodel development team, I have
tried to fix METAMODEL-205 and raised a code review for Kasper thru review
board review
https://reviews.apache.org/r/40074/
Please do have a look and please revert back for any changes.
Thanks & Regards,
Sai Krishna Kishore.
Re: METAMODEL-205 Code review
Posted by Sai Krishna Kishore Beathanabhotla <be...@gmail.com>.
Hi Kasper,
Thank you for updating me, I have added Metamodel group for code review.
Thanks & Regards,
Sai Krishna Kishore.
On Mon, Nov 9, 2015 at 3:30 PM, Kasper Sørensen <
i.am.kasper.sorensen@gmail.com> wrote:
> Hi Sai,
>
> Thank you a ton for your contribution and willingness to join! But just an
> important correction from my side - it's certainly not for *me *personally
> to review it. Anyone is invited and any contribution requires either 3
> committers' vote to pass or a lazy concensus by at least 1 committer (which
> could be me or any other committer).
>
> So that said, I hope someone else will give a look because right now I am a
> bit tied up, but might get time later.
>
> Kasper
>
> 2015-11-09 10:57 GMT+01:00 Sai Krishna Kishore Beathanabhotla <
> beathanabhotla.kishore@gmail.com>:
>
> > Hi,
> >
> > I am very much interested in joining the metamodel development team, I
> have
> > tried to fix METAMODEL-205 and raised a code review for Kasper thru
> review
> > board review
> >
> > https://reviews.apache.org/r/40074/
> >
> > Please do have a look and please revert back for any changes.
> >
> > Thanks & Regards,
> > Sai Krishna Kishore.
> >
>
Re: METAMODEL-205 Code review
Posted by Kasper Sørensen <i....@gmail.com>.
Hi Sai,
Thank you a ton for your contribution and willingness to join! But just an
important correction from my side - it's certainly not for *me *personally
to review it. Anyone is invited and any contribution requires either 3
committers' vote to pass or a lazy concensus by at least 1 committer (which
could be me or any other committer).
So that said, I hope someone else will give a look because right now I am a
bit tied up, but might get time later.
Kasper
2015-11-09 10:57 GMT+01:00 Sai Krishna Kishore Beathanabhotla <
beathanabhotla.kishore@gmail.com>:
> Hi,
>
> I am very much interested in joining the metamodel development team, I have
> tried to fix METAMODEL-205 and raised a code review for Kasper thru review
> board review
>
> https://reviews.apache.org/r/40074/
>
> Please do have a look and please revert back for any changes.
>
> Thanks & Regards,
> Sai Krishna Kishore.
>