[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1601: MINIFICPP-2143 - Resolve Security/UserID attribute

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1601:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1601#discussion_r1280477251


##########
extensions/windows-event-log/wel/MetadataWalker.cpp:
##########
@@ -171,4 +178,19 @@ void MetadataWalker::updateText(pugi::xml_node &node, const std::string &field_n
   }
 }
 
+template<typename Fn>
+requires std::is_convertible_v<std::invoke_result_t<Fn, std::string>, std::string>
+void MetadataWalker::updateText(pugi::xml_attribute &attr, const std::string &field_name, Fn &&fn) {

Review Comment:
   This function name is misleading, as we are not updating the text of the node, but the value of the attribute.  I would rename it to something like `updateAttributeValue`.



##########
extensions/windows-event-log/tests/resources/resolveduserid.xml:
##########


Review Comment:
   very minor, but why don't these test XML files have a newline at the end?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org