You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2018/08/07 21:15:16 UTC
[kudu-CR] Add const attribute to RpcContext::GetInboundSidecar()
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11150
Change subject: Add const attribute to RpcContext::GetInboundSidecar()
......................................................................
Add const attribute to RpcContext::GetInboundSidecar()
Testing done: rpc-test
Change-Id: Ie1d959c40aa119389b09c9f6ac2afe7445066a38
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/11150/1
--
To view, visit http://gerrit.cloudera.org:8080/11150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1d959c40aa119389b09c9f6ac2afe7445066a38
Gerrit-Change-Number: 11150
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[kudu-CR] Add const attribute to RpcContext::GetInboundSidecar()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11150 )
Change subject: Add const attribute to RpcContext::GetInboundSidecar()
......................................................................
Add const attribute to RpcContext::GetInboundSidecar()
Testing done: rpc-test
Change-Id: Ie1d959c40aa119389b09c9f6ac2afe7445066a38
Reviewed-on: http://gerrit.cloudera.org:8080/11150
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1d959c40aa119389b09c9f6ac2afe7445066a38
Gerrit-Change-Number: 11150
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add const attribute to RpcContext::GetInboundSidecar()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11150 )
Change subject: Add const attribute to RpcContext::GetInboundSidecar()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1d959c40aa119389b09c9f6ac2afe7445066a38
Gerrit-Change-Number: 11150
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 07 Aug 2018 21:23:41 +0000
Gerrit-HasComments: No