[GitHub] [superset] ktmud commented on a change in pull request #18856: feat(select): sort exact and startsWith match to first

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #18856:
URL: https://github.com/apache/superset/pull/18856#discussion_r819269328



##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -315,81 +325,44 @@ const Select = ({
     : allowNewOptions
     ? 'tags'
     : 'multiple';
-  const allowFetch = !fetchOnlyOnSearch || searchedValue;
-
-  // TODO: Don't assume that isAsync is always labelInValue
-  const handleTopOptions = useCallback(

Review comment:
       `handleTopOptions` is not needed anymore since we are handling sorting selected options to the top also in the sort comparator.

##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -577,7 +538,6 @@ const Select = ({
 
     if (filterOption) {
       const searchValue = search.trim().toLowerCase();

Review comment:
       We should probably remove trimming and case insensitivity treatment at this place since whitespaces and cases can be useful in search and ranking, too. For example, search "Le" may rank "Leah" first, but "Le " (with a space at the end) should rank things like "Le Monde" first.

##########
File path: superset-frontend/src/utils/rankedSearchCompare.ts
##########
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Sort comparator with basic rankings.
+ */
+export function rankedSearchCompare(a: string, b: string, search: string) {
+  const aLower = a.toLowerCase() || '';
+  const bLower = b.toLowerCase() || '';
+  const searchLower = search.toLowerCase() || '';
+  if (!search) return a.localeCompare(b);
+  return (
+    Number(b === search) - Number(a === search) ||
+    Number(b.startsWith(search)) - Number(a.startsWith(search)) ||

Review comment:
       Case sensitive matches will always be ranked to the top, rendering #18837 unnecessary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org