You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by analytically <gi...@git.apache.org> on 2016/05/03 20:15:49 UTC

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

GitHub user analytically opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/302

    Bump SLF4J to 1.7.21

    Releases 1.7.19 and 1.7.20 suffer from a memory leak. See http://www.slf4j.org/news.html.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/analytically/incubator-tinkerpop master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #302
    
----
commit ba34e6fa43c2bf42d84e934e3ab7d7851acaadab
Author: Mathias Bogaert <ma...@gmail.com>
Date:   2016-05-03T18:12:50Z

    Bump SLF4J to 1.7.21, releases 1.7.19 and 1.7.20 suffer from a memory leak.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/302#issuecomment-217235407
  
    Do you still plan to re-submit this PR? What you had looked good on #303 but it didn't base off of the `tp31` branch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

Posted by analytically <gi...@git.apache.org>.
Github user analytically commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/302#issuecomment-217310350
  
    #306


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

Posted by analytically <gi...@git.apache.org>.
Github user analytically commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/302#issuecomment-216902327
  
    Done, #303.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/302


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Bump SLF4J to 1.7.21

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/302#issuecomment-216897117
  
    Thanks for pointing this out. I think we should make this fix available on 3.1.x and 3.2.x. Can you please re-target this pull request for the `tp31` branch?  
    
    Also please update the LICENSE files here:
    
    * https://github.com/apache/incubator-tinkerpop/blob/tp31/gremlin-console/src/main/static/LICENSE#L227-L228
    * https://github.com/apache/incubator-tinkerpop/blob/tp31/gremlin-server/src/main/static/LICENSE#L226-L228
    
    Please also validate that the LICENSE file in the slf4j jars have not changed from the following:
    
    * https://github.com/apache/incubator-tinkerpop/blob/tp31/gremlin-console/src/main/static/licenses/slf4j
    * https://github.com/apache/incubator-tinkerpop/blob/tp31/gremlin-server/src/main/static/licenses/slf4j
    
    If they did, please update those as well. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---