You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2015/06/03 09:11:24 UTC

incubator-kylin git commit: minor, trigger job fetcher right after one step is finished

Repository: incubator-kylin
Updated Branches:
  refs/heads/0.8.0 890ade2a4 -> f2fa12708


minor, trigger job fetcher right after one step is finished


Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/f2fa1270
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/f2fa1270
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/f2fa1270

Branch: refs/heads/0.8.0
Commit: f2fa12708fc08cce115b9ea9774e66a8c359e1af
Parents: 890ade2
Author: Li, Yang <ya...@ebay.com>
Authored: Wed Jun 3 15:10:57 2015 +0800
Committer: Li, Yang <ya...@ebay.com>
Committed: Wed Jun 3 15:10:57 2015 +0800

----------------------------------------------------------------------
 .../apache/kylin/job/impl/threadpool/DefaultScheduler.java   | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/f2fa1270/job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
----------------------------------------------------------------------
diff --git a/job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java b/job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
index bac4227..c7eaf34 100644
--- a/job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
+++ b/job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
@@ -45,6 +45,7 @@ public class DefaultScheduler implements Scheduler<AbstractExecutable>, Connecti
 
 
     private ExecutableManager executableManager;
+    private FetcherRunner fetcher;
     private ScheduledExecutorService fetcherPool;
     private ExecutorService jobPool;
     private DefaultContext context;
@@ -62,7 +63,7 @@ public class DefaultScheduler implements Scheduler<AbstractExecutable>, Connecti
     private class FetcherRunner implements Runnable {
 
         @Override
-        public void run() {
+        synchronized public void run() {
             // logger.debug("Job Fetcher is running...");
             Map<String, Executable> runningJobs = context.getRunningJobs();
             if (runningJobs.size() >= jobEngineConfig.getMaxConcurrentJobLimit()) {
@@ -112,6 +113,8 @@ public class DefaultScheduler implements Scheduler<AbstractExecutable>, Connecti
         public void run() {
             try {
                 executable.execute(context);
+                // trigger the next step asap
+                fetcherPool.schedule(fetcher, 0, TimeUnit.SECONDS);
             } catch (ExecuteException e) {
                 logger.error("ExecuteException job:" + executable.getId(), e);
             } catch (Exception e) {
@@ -175,7 +178,8 @@ public class DefaultScheduler implements Scheduler<AbstractExecutable>, Connecti
             }
         });
 
-        fetcherPool.scheduleAtFixedRate(new FetcherRunner(), 10, ExecutableConstants.DEFAULT_SCHEDULER_INTERVAL_SECONDS, TimeUnit.SECONDS);
+        fetcher = new FetcherRunner();
+        fetcherPool.scheduleAtFixedRate(fetcher, 10, ExecutableConstants.DEFAULT_SCHEDULER_INTERVAL_SECONDS, TimeUnit.SECONDS);
         hasStarted = true;
     }